[clang] hipcc/ld.lld unable to link separable compilation when dynamic librar… (PR #169551)

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 26 10:21:18 PST 2025


================
@@ -241,15 +241,16 @@ class HIPUndefinedFatBinSymbols {
 
       bool isUndefined =
           FlagOrErr.get() & llvm::object::SymbolRef::SF_Undefined;
+      bool isHidden = FlagOrErr.get() & llvm::object::SymbolRef::SF_Hidden;
       bool isFatBinSymbol = Name.starts_with(FatBinPrefix);
       bool isGPUBinHandleSymbol = Name.starts_with(GPUBinHandlePrefix);
 
       // Handling for defined symbols
       if (!isUndefined) {
-        if (isFatBinSymbol) {
+        if ((isFatBinSymbol) && (!isHidden)) {
----------------
yxsamliu wrote:

the parenthesis are redundant. same as below.

https://github.com/llvm/llvm-project/pull/169551


More information about the cfe-commits mailing list