[libclc] [libclc] Fix typo in __clc_atomic_dec/inc functions (PR #168327)
Wenju He via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 25 17:49:18 PST 2025
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/168327
>From 4483912f7190985e42db607643067e3087ab0c83 Mon Sep 17 00:00:00 2001
From: Wenju He <wenju.he at intel.com>
Date: Mon, 17 Nov 2025 08:42:18 +0100
Subject: [PATCH 1/2] [libclc] Fix typo in __clc_atomic_dec/inc functions
---
libclc/clc/lib/generic/atomic/clc_atomic_dec.cl | 2 +-
libclc/clc/lib/generic/atomic/clc_atomic_inc.cl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl b/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl
index 7984dba5731ee..922d874ecfe4e 100644
--- a/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl
+++ b/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl
@@ -9,7 +9,7 @@
#include <clc/atomic/clc_atomic_dec.h>
#define __CLC_FUNCTION __clc_atomic_dec
-#define __CLC_IMPL_FUNCTION __scoped_atomic_fetch_add
+#define __CLC_IMPL_FUNCTION __scoped_atomic_fetch_sub
#define __CLC_INC_DEC
#define __CLC_BODY <clc_atomic_def.inc>
diff --git a/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl b/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl
index 7171f84c30ce0..bf1175a1d8280 100644
--- a/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl
+++ b/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl
@@ -9,7 +9,7 @@
#include <clc/atomic/clc_atomic_inc.h>
#define __CLC_FUNCTION __clc_atomic_inc
-#define __CLC_IMPL_FUNCTION __scoped_atomic_fetch_sub
+#define __CLC_IMPL_FUNCTION __scoped_atomic_fetch_add
#define __CLC_INC_DEC
#define __CLC_BODY <clc_atomic_def.inc>
>From 809b316c8d5e1ae53cc26f818a2d5412ab6c01db Mon Sep 17 00:00:00 2001
From: Wenju He <wenju.he at intel.com>
Date: Wed, 26 Nov 2025 02:46:56 +0100
Subject: [PATCH 2/2] use __scoped_atomic_uinc_wrap __scoped_atomic_udec_wrap
---
libclc/clc/lib/generic/atomic/clc_atomic_dec.cl | 2 +-
libclc/clc/lib/generic/atomic/clc_atomic_def.inc | 2 +-
libclc/clc/lib/generic/atomic/clc_atomic_inc.cl | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl b/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl
index 922d874ecfe4e..e0d24198d96d9 100644
--- a/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl
+++ b/libclc/clc/lib/generic/atomic/clc_atomic_dec.cl
@@ -9,7 +9,7 @@
#include <clc/atomic/clc_atomic_dec.h>
#define __CLC_FUNCTION __clc_atomic_dec
-#define __CLC_IMPL_FUNCTION __scoped_atomic_fetch_sub
+#define __CLC_IMPL_FUNCTION __scoped_atomic_udec_wrap
#define __CLC_INC_DEC
#define __CLC_BODY <clc_atomic_def.inc>
diff --git a/libclc/clc/lib/generic/atomic/clc_atomic_def.inc b/libclc/clc/lib/generic/atomic/clc_atomic_def.inc
index 75561430b33ad..6926b82248bf9 100644
--- a/libclc/clc/lib/generic/atomic/clc_atomic_def.inc
+++ b/libclc/clc/lib/generic/atomic/clc_atomic_def.inc
@@ -46,7 +46,7 @@
_CLC_OVERLOAD _CLC_DEF __CLC_GENTYPE __CLC_FUNCTION( \
volatile ADDRSPACE __CLC_GENTYPE *Ptr, int MemoryOrder, \
int MemoryScope) { \
- return __CLC_IMPL_FUNCTION(Ptr, (__CLC_GENTYPE)1, MemoryOrder, \
+ return __CLC_IMPL_FUNCTION(Ptr, (__CLC_U_GENTYPE)(-1), MemoryOrder, \
MemoryScope); \
}
#elif defined(__CLC_RETURN_VOID)
diff --git a/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl b/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl
index bf1175a1d8280..d594754677800 100644
--- a/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl
+++ b/libclc/clc/lib/generic/atomic/clc_atomic_inc.cl
@@ -9,7 +9,7 @@
#include <clc/atomic/clc_atomic_inc.h>
#define __CLC_FUNCTION __clc_atomic_inc
-#define __CLC_IMPL_FUNCTION __scoped_atomic_fetch_add
+#define __CLC_IMPL_FUNCTION __scoped_atomic_uinc_wrap
#define __CLC_INC_DEC
#define __CLC_BODY <clc_atomic_def.inc>
More information about the cfe-commits
mailing list