[clang] [clang][deps][NFC] Replace a vector with an array (PR #169555)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 25 11:30:01 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: David Stone (davidstone)
<details>
<summary>Changes</summary>
`ResourceDirectoryCache::findResourceDir` uses a `std::vector` when a `std::array` would do.
---
Full diff: https://github.com/llvm/llvm-project/pull/169555.diff
1 Files Affected:
- (modified) clang/tools/clang-scan-deps/ClangScanDeps.cpp (+3-5)
``````````diff
diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
index 5f5bf42df5e6b..3efa28b0469c1 100644
--- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp
+++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -284,11 +284,9 @@ class ResourceDirectoryCache {
if (CachedResourceDir != Cache.end())
return CachedResourceDir->second;
- std::vector<StringRef> PrintResourceDirArgs{ClangBinaryName};
- if (ClangCLMode)
- PrintResourceDirArgs.push_back("/clang:-print-resource-dir");
- else
- PrintResourceDirArgs.push_back("-print-resource-dir");
+ const std::array<StringRef, 2> PrintResourceDirArgs{
+ ClangBinaryName,
+ ClangCLMode ? "/clang:-print-resource-dir" : "-print-resource-dir"};
llvm::SmallString<64> OutputFile, ErrorFile;
llvm::sys::fs::createTemporaryFile("print-resource-dir-output",
``````````
</details>
https://github.com/llvm/llvm-project/pull/169555
More information about the cfe-commits
mailing list