[clang] [clang-format] Fix designated initializer detection (PR #169228)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 84732 tests passed
* 1108 tests skipped
* 2 tests failed

## Failed Tests
(click on a test name to see its output)

### Clang-Unit
<details>
<summary>Clang-Unit.Format/_/FormatTests/FormatTestObjC/ObjCDictLiterals</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/unittests/Format/./FormatTests --gtest_filter=FormatTestObjC.ObjCDictLiterals
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Format/FormatTestBase.h:90
Expected equality of these values:
  ExpectedCode
    Which is: "NSDictionary *d = @{\n  @\"nam\" : NSUserNam(),\n  @\"dte\" : [NSDate date],\n  @\"processInfo\" : [NSProcessInfo processInfo]\n};"
  FormattedCode
    Which is: "NSDictionary *d = @{\n  @\"nam\" : NSUserNam(),\n  @\"dte\" : [ NSDate date ],\n  @\"processInfo\" : [ NSProcessInfo processInfo ]\n};"
With diff:
@@ -1,5 +1,5 @@
 NSDictionary *d = @{
   @\"nam\" : NSUserNam(),
-  @\"dte\" : [NSDate date],
-  @\"processInfo\" : [NSProcessInfo processInfo]
+  @\"dte\" : [ NSDate date ],
+  @\"processInfo\" : [ NSProcessInfo processInfo ]
 };

Google Test trace:
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Format/FormatTestObjC.cpp:1253: NSDictionary *d = @{
  @"nam" : NSUserNam(),
  @"dte" : [NSDate date],
  @"processInfo" : [NSProcessInfo processInfo]
};

/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Format/FormatTestBase.h:90
Expected equality of these values:
  ExpectedCode
    Which is: "NSDictionary *d = {\n  @\"nam\" : NSUserNam(),\n  @\"dte\" : [NSDate date],\n  @\"processInfo\" : [NSProcessInfo processInfo]\n};"
  FormattedCode
    Which is: "NSDictionary *d = {\n  @\"nam\" : NSUserNam(),\n  @\"dte\" : [ NSDate date ],\n  @\"processInfo\" : [ NSProcessInfo processInfo ]\n};"
With diff:
@@ -1,5 +1,5 @@
 NSDictionary *d = {
   @\"nam\" : NSUserNam(),
-  @\"dte\" : [NSDate date],
-  @\"processInfo\" : [NSProcessInfo processInfo]
+  @\"dte\" : [ NSDate date ],
+  @\"processInfo\" : [ NSProcessInfo processInfo ]
 };

Google Test trace:
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Format/FormatTestObjC.cpp:1270: NSDictionary *d = {
  @"nam" : NSUserNam(),
  @"dte" : [NSDate date],
  @"processInfo" : [NSProcessInfo processInfo]
};


```
</details>
<details>
<summary>Clang-Unit.Format/_/FormatTests/TokenAnnotatorTest/UnderstandDesignatedInitializers</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/unittests/Format/./FormatTests --gtest_filter=TokenAnnotatorTest.UnderstandDesignatedInitializers
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Format/TokenAnnotatorTest.cpp:3377
Expected equality of these values:
  (Tokens[12])->getType()
    Which is: ¨
  TT_DesignatedInitializerLSquare
    Which is: '
(l_square, "[" , Unknown)


```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/169228