[clang-tools-extra] [clang-tidy] Add misc-bool-bitwise-operation check (PR #167552)
Denis Mikhailov via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 19 13:50:31 PST 2025
================
@@ -0,0 +1,302 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "BoolBitwiseOperationCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Lexer.h"
+#include <array>
+#include <optional>
+#include <utility>
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::misc {
+
+static const DynTypedNode *ignoreParensTowardsTheRoot(const DynTypedNode *N,
+ ASTContext *AC) {
+ if (const auto *S = N->get<Stmt>()) {
+ if (isa<ParenExpr>(S)) {
+ auto Parents = AC->getParents(*S);
+ // FIXME: do we need to consider all `Parents` ?
+ if (!Parents.empty())
+ return ignoreParensTowardsTheRoot(&Parents[0], AC);
+ }
+ }
+ return N;
+}
+
+static bool assignsToBoolean(const BinaryOperator *BinOp, ASTContext *AC) {
+ TraversalKindScope RAII(*AC, TK_AsIs);
+ auto Parents = AC->getParents(*BinOp);
+
+ return llvm::any_of(Parents, [&](const DynTypedNode &Parent) {
+ const auto *S = ignoreParensTowardsTheRoot(&Parent, AC)->get<Stmt>();
+ const auto *ICE = dyn_cast_if_present<ImplicitCastExpr>(S);
+ return ICE ? ICE->getType().getDesugaredType(*AC)->isBooleanType() : false;
+ });
+}
+
+static constexpr std::array<std::pair<StringRef, StringRef>, 8U>
----------------
denzor200 wrote:
See [modernize-avoid-c-arrays](https://clang.llvm.org/extra/clang-tidy/checks/modernize/avoid-c-arrays.html)
https://github.com/llvm/llvm-project/pull/167552
More information about the cfe-commits
mailing list