[clang] [clang][analyzer] Add defer_lock_t modelling to BlockInCriticalSectionChecker (PR #168338)

[via cfe-commits]

Endre =?utf-8?q?Fülöp?= <gamesh411 at gmail.com>,
Endre =?utf-8?q?Fülöp?= <gamesh411 at gmail.com>,Alan Li
 <me at alanli.org>,
Endre =?utf-8?q?Fülöp?= <endre.fulop at sigmatechnology.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/168338 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp clang/test/Analysis/block-in-critical-section.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp
index 9f6487f9e..2db531027 100644
--- a/clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp
@@ -125,8 +125,7 @@ class RAIIMutexDescriptor {
         const Expr *SecondArg = C->getArgExpr(1);
         QualType ArgType = SecondArg->getType().getNonReferenceType();
         if (const auto *RD = ArgType->getAsRecordDecl();
-            RD && RD->getName() == "defer_lock_t" &&
-            RD->isInStdNamespace()) {
+            RD && RD->getName() == "defer_lock_t" && RD->isInStdNamespace()) {
           return false;
         }
       }

``````````

</details>


https://github.com/llvm/llvm-project/pull/168338