[clang-tools-extra] [clang-tidy] New bugprone-unsafe-format-string check (PR #168691)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE LINT COMMENT: clang-tidy-->


:warning: C/C++ code linter clang-tidy found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

```bash

git diff -U0 origin/main...HEAD -- clang-tools-extra/clang-tidy/bugprone/UnsafeFormatStringCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnsafeFormatStringCheck.h clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \
  -path build -p1 -quiet
```

</details>

<details>
<summary>
View the output from clang-tidy here.
</summary>

```

clang-tools-extra/clang-tidy/bugprone/UnsafeFormatStringCheck.h:28:8: warning: function 'clang::tidy::bugprone::UnsafeFormatStringCheck::hasUnboundedStringSpecifier' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
   28 |   bool hasUnboundedStringSpecifier(StringRef FormatString, bool IsScanfFamily);
      |        ^
clang-tools-extra/clang-tidy/bugprone/UnsafeFormatStringCheck.cpp:71:31: note: the definition seen here
   71 | bool UnsafeFormatStringCheck::hasUnboundedStringSpecifier(StringRef Fmt,
      |                               ^
clang-tools-extra/clang-tidy/bugprone/UnsafeFormatStringCheck.h:28:8: note: differing parameters are named here: ('FormatString'), in definition: ('Fmt')
   28 |   bool hasUnboundedStringSpecifier(StringRef FormatString, bool IsScanfFamily);
      |        ^                                     ~~~~~~~~~~~~
      |                                              Fmt
```

</details>


https://github.com/llvm/llvm-project/pull/168691