[clang] [LifetimeSafety] Detect use-after-return (PR #165370)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o</summary>

```
FAILED: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o
sccache /opt/llvm/bin/clang++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/lib/Analysis/LifetimeSafety -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o -MF tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o.d -o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety/LoanPropagation.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety/LoanPropagation.cpp:61:24: error: no member named 'ReturnOfOrigin' in 'clang::lifetimes::internal::Fact::Kind'
61 |       case Fact::Kind::ReturnOfOrigin:
|                        ^~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety/LoanPropagation.cpp:62:30: error: use of undeclared identifier 'ReturnOfOriginFact'
62 |         CheckOrigin(F->getAs<ReturnOfOriginFact>()->getReturnedOriginID());
|                              ^~~~~~~~~~~~~~~~~~
2 errors generated.
```
</details>
<details>
<summary>tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o</summary>

```
FAILED: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o
sccache /opt/llvm/bin/clang++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/lib/Analysis/LifetimeSafety -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o -MF tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o.d -o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety/Facts.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety/Facts.cpp:101:28: error: use of undeclared identifier 'BlockToFactsMap'; did you mean 'BlockToFacts'?
101 |   for (const auto &Entry : BlockToFactsMap) {
|                            ^~~~~~~~~~~~~~~
|                            BlockToFacts
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h:247:54: note: 'BlockToFacts' declared here
247 |   llvm::SmallVector<llvm::SmallVector<const Fact *>> BlockToFacts;
|                                                      ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/Analysis/LifetimeSafety/Facts.cpp:102:31: error: no member named 'second' in 'llvm::SmallVector<const clang::lifetimes::internal::Fact *>'
102 |     const auto &Facts = Entry.second;
|                         ~~~~~ ^
2 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/165370