[clang] [mlir] [mlir][LLVM] Resync memory effect attribute with LLVM IR (PR #168568)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 18 09:00:49 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: None (darkbuck)
<details>
<summary>Changes</summary>
- Add missing locations, namely 'ErrnoMem', 'TargetMem0', and 'TargetMem1'.
---
Patch is 37.56 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/168568.diff
18 Files Affected:
- (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp (+8-2)
- (modified) clang/test/CIR/CodeGen/call.c (+1-1)
- (modified) mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td (+3-5)
- (modified) mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp (+6-3)
- (modified) mlir/lib/Conversion/GPUToLLVMSPV/GPUToLLVMSPV.cpp (+4-1)
- (modified) mlir/lib/Conversion/XeVMToLLVM/XeVMToLLVM.cpp (+20-5)
- (modified) mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp (+16-4)
- (modified) mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp (+8-1)
- (modified) mlir/lib/Target/LLVMIR/ModuleImport.cpp (+18-4)
- (modified) mlir/lib/Target/LLVMIR/ModuleTranslation.cpp (+9)
- (modified) mlir/test/Conversion/FuncToLLVM/convert-funcs.mlir (+1-1)
- (modified) mlir/test/Conversion/XeVMToLLVM/xevm-to-llvm.mlir (+13-13)
- (modified) mlir/test/Dialect/LLVMIR/func.mlir (+2-2)
- (modified) mlir/test/Dialect/LLVMIR/inlining.mlir (+7-7)
- (modified) mlir/test/Dialect/LLVMIR/roundtrip.mlir (+2-2)
- (modified) mlir/test/Target/LLVMIR/Import/function-attributes.ll (+3-3)
- (modified) mlir/test/Target/LLVMIR/Import/instructions.ll (+4-4)
- (modified) mlir/test/Target/LLVMIR/llvmir.mlir (+6-6)
``````````diff
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index d43a462a25092..c796c9c907af8 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -284,7 +284,10 @@ void convertSideEffectForCall(mlir::Operation *callOp, bool isNothrow,
memoryEffect = mlir::LLVM::MemoryEffectsAttr::get(
callOp->getContext(), /*other=*/ModRefInfo::Ref,
/*argMem=*/ModRefInfo::Ref,
- /*inaccessibleMem=*/ModRefInfo::Ref);
+ /*inaccessibleMem=*/ModRefInfo::Ref,
+ /*errnoMem=*/ModRefInfo::Ref,
+ /*targetMem0=*/ModRefInfo::Ref,
+ /*targetMem1=*/ModRefInfo::Ref);
noUnwind = true;
willReturn = true;
break;
@@ -293,7 +296,10 @@ void convertSideEffectForCall(mlir::Operation *callOp, bool isNothrow,
memoryEffect = mlir::LLVM::MemoryEffectsAttr::get(
callOp->getContext(), /*other=*/ModRefInfo::NoModRef,
/*argMem=*/ModRefInfo::NoModRef,
- /*inaccessibleMem=*/ModRefInfo::NoModRef);
+ /*inaccessibleMem=*/ModRefInfo::NoModRef,
+ /*errnoMem=*/ModRefInfo::NoModRef,
+ /*targetMem0=*/ModRefInfo::NoModRef,
+ /*targetMem1=*/ModRefInfo::NoModRef);
noUnwind = true;
willReturn = true;
break;
diff --git a/clang/test/CIR/CodeGen/call.c b/clang/test/CIR/CodeGen/call.c
index 99ae4506b1f16..35d977f2b3dac 100644
--- a/clang/test/CIR/CodeGen/call.c
+++ b/clang/test/CIR/CodeGen/call.c
@@ -130,7 +130,7 @@ int f12(void) {
// OGCG: %{{.+}} = call i32 @f10(i32 noundef 1) #[[ATTR0:.+]]
// OGCG-NEXT: %{{.+}} = call i32 @f11(i32 noundef 2) #[[ATTR1:.+]]
-// LLVM: attributes #[[ATTR0]] = { nounwind willreturn memory(read, errnomem: none, target_mem0: none, target_mem1: none) }
+// LLVM: attributes #[[ATTR0]] = { nounwind willreturn memory(read) }
// LLVM: attributes #[[ATTR1]] = { nounwind willreturn memory(none) }
// OGCG: attributes #[[ATTR0]] = { nounwind willreturn memory(read) }
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
index 147f8c2040049..ef16cec7c9e71 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
@@ -931,11 +931,9 @@ def LLVM_DIStringTypeAttr : LLVM_Attr<"DIStringType", "di_string_type",
//===----------------------------------------------------------------------===//
def LLVM_MemoryEffectsAttr : LLVM_Attr<"MemoryEffects", "memory_effects"> {
- let parameters = (ins
- "ModRefInfo":$other,
- "ModRefInfo":$argMem,
- "ModRefInfo":$inaccessibleMem
- );
+ let parameters = (ins "ModRefInfo":$other, "ModRefInfo":$argMem,
+ "ModRefInfo":$inaccessibleMem, "ModRefInfo":$errnoMem,
+ "ModRefInfo":$targetMem0, "ModRefInfo":$targetMem1);
let extraClassDeclaration = [{
bool isReadWrite();
}];
diff --git a/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp b/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
index 93fe2edad5274..2220f61ed8a07 100644
--- a/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
+++ b/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
@@ -374,9 +374,12 @@ FailureOr<LLVM::LLVMFuncOp> mlir::convertFuncOpToLLVMFuncOp(
// Create a memory effect attribute corresponding to readnone.
if (funcOp->hasAttr(readnoneAttrName)) {
auto memoryAttr = LLVM::MemoryEffectsAttr::get(
- rewriter.getContext(),
- {LLVM::ModRefInfo::NoModRef, LLVM::ModRefInfo::NoModRef,
- LLVM::ModRefInfo::NoModRef});
+ rewriter.getContext(), {/*other=*/LLVM::ModRefInfo::NoModRef,
+ /*argMem=*/LLVM::ModRefInfo::NoModRef,
+ /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef,
+ /*errnoMem=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem0=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem1=*/LLVM::ModRefInfo::NoModRef});
newFuncOp.setMemoryEffectsAttr(memoryAttr);
}
diff --git a/mlir/lib/Conversion/GPUToLLVMSPV/GPUToLLVMSPV.cpp b/mlir/lib/Conversion/GPUToLLVMSPV/GPUToLLVMSPV.cpp
index 425594b3382f0..f143a9e505f4d 100644
--- a/mlir/lib/Conversion/GPUToLLVMSPV/GPUToLLVMSPV.cpp
+++ b/mlir/lib/Conversion/GPUToLLVMSPV/GPUToLLVMSPV.cpp
@@ -66,7 +66,10 @@ static LLVM::LLVMFuncOp lookupOrCreateSPIRVFn(Operation *symbolTable,
constexpr auto noModRef = mlir::LLVM::ModRefInfo::NoModRef;
auto memAttr = b.getAttr<LLVM::MemoryEffectsAttr>(
/*other=*/noModRef,
- /*argMem=*/noModRef, /*inaccessibleMem=*/noModRef);
+ /*argMem=*/noModRef, /*inaccessibleMem=*/noModRef,
+ /*errnoMem=*/noModRef,
+ /*targetMem0=*/noModRef,
+ /*targetMem1=*/noModRef);
func.setMemoryEffectsAttr(memAttr);
}
diff --git a/mlir/lib/Conversion/XeVMToLLVM/XeVMToLLVM.cpp b/mlir/lib/Conversion/XeVMToLLVM/XeVMToLLVM.cpp
index f2769846abbd9..dffb1dab807a5 100644
--- a/mlir/lib/Conversion/XeVMToLLVM/XeVMToLLVM.cpp
+++ b/mlir/lib/Conversion/XeVMToLLVM/XeVMToLLVM.cpp
@@ -401,7 +401,10 @@ class MMAToOCLPattern : public OpConversionPattern<xevm::MMAOp> {
auto memAttr = rewriter.getAttr<LLVM::MemoryEffectsAttr>(
/*other=*/LLVM::ModRefInfo::NoModRef,
/*argMem=*/LLVM::ModRefInfo::NoModRef,
- /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef);
+ /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef,
+ /*errnoMem=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem0=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem1=*/LLVM::ModRefInfo::NoModRef);
auto funcAttrs = convergentNoUnwindWillReturnAttrs;
funcAttrs.memEffectsAttr = memAttr;
Value result =
@@ -450,7 +453,10 @@ class PrefetchToOCLPattern : public OpConversionPattern<PrefetchOp> {
auto memAttr = rewriter.getAttr<LLVM::MemoryEffectsAttr>(
/*other=*/LLVM::ModRefInfo::NoModRef,
/*argMem=*/LLVM::ModRefInfo::Ref,
- /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef);
+ /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef,
+ /*errnoMem=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem0=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem1=*/LLVM::ModRefInfo::NoModRef);
funcAttr.memEffectsAttr = memAttr;
LLVM::CallOp call = createDeviceFunctionCall(
@@ -556,7 +562,10 @@ class LoadStorePrefetchToOCLPattern : public OpConversionPattern<OpType> {
auto memAttr = rewriter.getAttr<LLVM::MemoryEffectsAttr>(
/*other=*/LLVM::ModRefInfo::NoModRef,
/*argMem=*/LLVM::ModRefInfo::Ref,
- /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef);
+ /*inaccessibleMem=*/LLVM::ModRefInfo::NoModRef,
+ /*errnoMem=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem0=*/LLVM::ModRefInfo::NoModRef,
+ /*targetMem1=*/LLVM::ModRefInfo::NoModRef);
funcAttr = noUnwindAttrs;
funcAttr.memEffectsAttr = memAttr;
} else {
@@ -798,7 +807,10 @@ class LaunchConfigOpToOCLPattern : public OpConversionPattern<OpType> {
constexpr auto noModRef = LLVM::ModRefInfo::NoModRef;
auto memAttr = rewriter.getAttr<LLVM::MemoryEffectsAttr>(
/*other=*/noModRef,
- /*argMem=*/noModRef, /*inaccessibleMem=*/noModRef);
+ /*argMem=*/noModRef, /*inaccessibleMem=*/noModRef,
+ /*errnoMem=*/noModRef,
+ /*targetMem0=*/noModRef,
+ /*targetMem1=*/noModRef);
call.setMemoryEffectsAttr(memAttr);
rewriter.replaceOp(op, call);
return success();
@@ -836,7 +848,10 @@ class SubgroupOpWorkitemOpToOCLPattern : public OpConversionPattern<OpType> {
constexpr auto noModRef = LLVM::ModRefInfo::NoModRef;
auto memAttr = rewriter.getAttr<LLVM::MemoryEffectsAttr>(
/*other=*/noModRef,
- /*argMem=*/noModRef, /*inaccessibleMem=*/noModRef);
+ /*argMem=*/noModRef, /*inaccessibleMem=*/noModRef,
+ /*errnoMem=*/noModRef,
+ /*targetMem0=*/noModRef,
+ /*targetMem1=*/noModRef);
call.setMemoryEffectsAttr(memAttr);
rewriter.replaceOp(op, call);
return success();
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
index b8331e0068880..a8ba06bc7bff1 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
@@ -219,11 +219,17 @@ bool TBAANodeAttr::classof(Attribute attr) {
MemoryEffectsAttr MemoryEffectsAttr::get(MLIRContext *context,
ArrayRef<ModRefInfo> memInfoArgs) {
if (memInfoArgs.empty())
- return MemoryEffectsAttr::get(context, ModRefInfo::ModRef,
- ModRefInfo::ModRef, ModRefInfo::ModRef);
- if (memInfoArgs.size() == 3)
+ return MemoryEffectsAttr::get(context, /*other=*/ModRefInfo::ModRef,
+ /*argMem=*/ModRefInfo::ModRef,
+ /*inaccessibleMem=*/ModRefInfo::ModRef,
+ /*errnoMem=*/ModRefInfo::ModRef,
+ /*targetMem0=*/ModRefInfo::ModRef,
+ /*targetMem1=*/ModRefInfo::ModRef);
+ assert(memInfoArgs.size() == 6);
+ if (memInfoArgs.size() == 6)
return MemoryEffectsAttr::get(context, memInfoArgs[0], memInfoArgs[1],
- memInfoArgs[2]);
+ memInfoArgs[2], memInfoArgs[3],
+ memInfoArgs[4], memInfoArgs[5]);
return {};
}
@@ -234,6 +240,12 @@ bool MemoryEffectsAttr::isReadWrite() {
return false;
if (this->getOther() != ModRefInfo::ModRef)
return false;
+ if (this->getErrnoMem() != ModRefInfo::ModRef)
+ return false;
+ if (this->getTargetMem0() != ModRefInfo::ModRef)
+ return false;
+ if (this->getTargetMem1() != ModRefInfo::ModRef)
+ return false;
return true;
}
diff --git a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
index eaf1d20da63c7..43ce2ef4fefab 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
@@ -439,7 +439,14 @@ convertOperationImpl(Operation &opInst, llvm::IRBuilderBase &builder,
llvm::MemoryEffects::Location::InaccessibleMem,
convertModRefInfoToLLVM(memAttr.getInaccessibleMem())) |
llvm::MemoryEffects(llvm::MemoryEffects::Location::Other,
- convertModRefInfoToLLVM(memAttr.getOther()));
+ convertModRefInfoToLLVM(memAttr.getOther())) |
+ llvm::MemoryEffects(llvm::MemoryEffects::Location::ErrnoMem,
+ convertModRefInfoToLLVM(memAttr.getErrnoMem())) |
+ llvm::MemoryEffects(
+ llvm::MemoryEffects::Location::TargetMem0,
+ convertModRefInfoToLLVM(memAttr.getTargetMem0())) |
+ llvm::MemoryEffects(llvm::MemoryEffects::Location::TargetMem1,
+ convertModRefInfoToLLVM(memAttr.getTargetMem1()));
call->setMemoryEffects(memEffects);
}
diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
index b8106101692b8..4d63e0534358f 100644
--- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
@@ -2597,8 +2597,15 @@ static void processMemoryEffects(llvm::Function *func, LLVMFuncOp funcOp) {
memEffects.getModRef(llvm::MemoryEffects::Location::ArgMem));
auto inaccessibleMem = convertModRefInfoFromLLVM(
memEffects.getModRef(llvm::MemoryEffects::Location::InaccessibleMem));
- auto memAttr = MemoryEffectsAttr::get(funcOp.getContext(), othermem, argMem,
- inaccessibleMem);
+ auto errnoMem = convertModRefInfoFromLLVM(
+ memEffects.getModRef(llvm::MemoryEffects::Location::ErrnoMem));
+ auto targetMem0 = convertModRefInfoFromLLVM(
+ memEffects.getModRef(llvm::MemoryEffects::Location::TargetMem0));
+ auto targetMem1 = convertModRefInfoFromLLVM(
+ memEffects.getModRef(llvm::MemoryEffects::Location::TargetMem1));
+ auto memAttr =
+ MemoryEffectsAttr::get(funcOp.getContext(), othermem, argMem,
+ inaccessibleMem, errnoMem, targetMem0, targetMem1);
// Only set the attr when it does not match the default value.
if (memAttr.isReadWrite())
return;
@@ -2903,8 +2910,15 @@ LogicalResult ModuleImport::convertCallAttributes(llvm::CallInst *inst,
memEffects.getModRef(llvm::MemoryEffects::Location::ArgMem));
ModRefInfo inaccessibleMem = convertModRefInfoFromLLVM(
memEffects.getModRef(llvm::MemoryEffects::Location::InaccessibleMem));
- auto memAttr = MemoryEffectsAttr::get(op.getContext(), othermem, argMem,
- inaccessibleMem);
+ ModRefInfo errnoMem = convertModRefInfoFromLLVM(
+ memEffects.getModRef(llvm::MemoryEffects::Location::ErrnoMem));
+ ModRefInfo targetMem0 = convertModRefInfoFromLLVM(
+ memEffects.getModRef(llvm::MemoryEffects::Location::TargetMem0));
+ ModRefInfo targetMem1 = convertModRefInfoFromLLVM(
+ memEffects.getModRef(llvm::MemoryEffects::Location::TargetMem1));
+ auto memAttr =
+ MemoryEffectsAttr::get(op.getContext(), othermem, argMem, inaccessibleMem,
+ errnoMem, targetMem0, targetMem1);
// Only set the attribute when it does not match the default value.
if (!memAttr.isReadWrite())
op.setMemoryEffectsAttr(memAttr);
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index 64e3c5f085bb3..4107e9c14507f 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -1637,6 +1637,15 @@ static void convertFunctionMemoryAttributes(LLVMFuncOp func,
newMemEffects |=
llvm::MemoryEffects(llvm::MemoryEffects::Location::Other,
convertModRefInfoToLLVM(memEffects.getOther()));
+ newMemEffects |=
+ llvm::MemoryEffects(llvm::MemoryEffects::Location::ErrnoMem,
+ convertModRefInfoToLLVM(memEffects.getErrnoMem()));
+ newMemEffects |=
+ llvm::MemoryEffects(llvm::MemoryEffects::Location::TargetMem0,
+ convertModRefInfoToLLVM(memEffects.getTargetMem0()));
+ newMemEffects |=
+ llvm::MemoryEffects(llvm::MemoryEffects::Location::TargetMem1,
+ convertModRefInfoToLLVM(memEffects.getTargetMem1()));
llvmFunc->setMemoryEffects(newMemEffects);
}
diff --git a/mlir/test/Conversion/FuncToLLVM/convert-funcs.mlir b/mlir/test/Conversion/FuncToLLVM/convert-funcs.mlir
index ae1dc70d0686b..bd281620c2918 100644
--- a/mlir/test/Conversion/FuncToLLVM/convert-funcs.mlir
+++ b/mlir/test/Conversion/FuncToLLVM/convert-funcs.mlir
@@ -32,7 +32,7 @@ func.func @pass_through(%arg0: () -> ()) -> (() -> ()) {
func.func private @llvmlinkage(i32) attributes { "llvm.linkage" = #llvm.linkage<extern_weak> }
// CHECK-LABEL: llvm.func @llvmreadnone(i32)
-// CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = none, inaccessibleMem = none>
+// CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = none, inaccessibleMem = none, errnoMem = none, targetMem0 = none, targetMem1 = none>
func.func private @llvmreadnone(i32) attributes { llvm.readnone }
// CHECK-LABEL: llvm.func @body(i32)
diff --git a/mlir/test/Conversion/XeVMToLLVM/xevm-to-llvm.mlir b/mlir/test/Conversion/XeVMToLLVM/xevm-to-llvm.mlir
index 72e70ff519b77..7f01526cb0a06 100644
--- a/mlir/test/Conversion/XeVMToLLVM/xevm-to-llvm.mlir
+++ b/mlir/test/Conversion/XeVMToLLVM/xevm-to-llvm.mlir
@@ -175,7 +175,7 @@ llvm.func @blockstore2d_cache_control(%c: !llvm.ptr<1>, %base_width_c: i32, %bas
// -----
// CHECK-LABEL: llvm.func spir_funccc @_Z44intel_sub_group_2d_block_prefetch_8b_8r32x1cPU3AS1viiiDv2_i(
// CHECK-SAME: !llvm.ptr<1> {llvm.nonnull}, i32, i32, i32, vector<2xi32>) attributes
-// CHECK-SAME: {memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none>, no_unwind}
+// CHECK-SAME: {memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none, errnoMem = none, targetMem0 = none, targetMem1 = none>, no_unwind}
// CHECK: llvm.func @blockprefetch2d(%[[ARG0:.*]]: !llvm.ptr<1>,
// CHECK-SAME: %[[ARG1:.*]]: i32, %[[ARG2:.*]]: i32, %[[ARG3:.*]]: i32, %[[ARG4:.*]]: i32, %[[ARG5:.*]]: i32) {
llvm.func @blockprefetch2d(%ptr: !llvm.ptr<1>, %base_width: i32, %base_height: i32, %base_pitch: i32, %x: i32, %y: i32) {
@@ -187,7 +187,7 @@ llvm.func @blockprefetch2d(%ptr: !llvm.ptr<1>, %base_width: i32, %base_height: i
// CHECK: llvm.call spir_funccc @_Z44intel_sub_group_2d_block_prefetch_8b_8r32x1cPU3AS1viiiDv2_i(
// CHECK-SAME: %[[ARG0]], %[[ARG1]], %[[ARG2]], %[[ARG3]], %[[VAR4]])
// CHECK-SAME: {function_type = !llvm.func<void (ptr<1>, i32, i32, i32, vector<2xi32>)>, linkage = #llvm.linkage<external>,
- // CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none>, no_unwind,
+ // CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none, errnoMem = none, targetMem0 = none, targetMem1 = none>, no_unwind,
// CHECK-SAME: sym_name = "_Z44intel_sub_group_2d_block_prefetch_8b_8r32x1cPU3AS1viiiDv2_i", visibility_ = 0 : i64
xevm.blockprefetch2d %ptr, %base_width, %base_height, %base_pitch, %x, %y
<{elem_size_in_bits=8 : i32, tile_width=32 : i32, tile_height=8 : i32, v_blocks=1 : i32,
@@ -200,13 +200,13 @@ llvm.func @blockprefetch2d(%ptr: !llvm.ptr<1>, %base_width: i32, %base_height: i
// CHECK-LABEL: llvm.func spir_funccc @_Z38intel_sub_group_f16_f16_matrix_mad_k16Dv8_sDv8_iDv8_f(
// CHECK-SAME: vector<8xi16>, vector<8xi32>, vector<8xf32>) -> vector<8xf32> attributes
// CHECK-SAME: {convergent, memory_effects = #llvm.memory_effects<other = none, argMem = none,
-// CHECK-SAME: inaccessibleMem = none>, no_unwind, will_return}
+// CHECK-SAME: inaccessibleMem = none, errnoMem = none, targetMem0 = none, targetMem1 = none>, no_unwind, will_return}
// CHECK: llvm.func @mma(%[[ARG0:.*]]: vector<8xf32>, %[[ARG1:.*]]: vector<8xi16>, %[[ARG2:.*]]: vector<8xi32>) -> vector<8xf32> {
llvm.func @mma(%loaded_c_casted: vector<8xf32>, %loaded_a: vector<8xi16>, %loaded_b_casted: vector<8xi32>) -> vector<8xf32> {
// CHECK: %[[VAR0:.*]] = llvm.call spir_funccc @_Z38intel_sub_group_f16_f16_matrix_mad_k16Dv8_sDv8_iDv8_f(
// CHECK-SAME: %[[ARG1]], %[[ARG2]], %[[ARG0]]) {convergent, function_type =
// CHECK-SAME: !llvm.func<vector<8xf32> (vector<8xi16>, vector<8xi32>, vector<8xf32>)>, linkage = #llvm.linkage<external>,
- // CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = none, inaccessibleMem = none>, no_unwind,
+ // CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = none, inaccessibleMem = none, errnoMem = none, targetMem0 = none, targetMem1 = none>, no_unwind,
// CHECK-SAME: sym_name = "_Z38intel_sub_group_f16_f16_matrix_mad_k16Dv8_sDv8_iDv8_f", visibility_ = 0 : i64, will_return}
// CHECK-SAME: : (vector<8xi16>, vector<8xi32>, vector<8xf32>) -> vector<8xf32>
%c_result = xevm.mma %loaded_a, %loaded_b_casted, %loaded_c_casted
@@ -230,13 +230,13 @@ llvm.func @memfence() {
// -----
// CHECK-LABEL: llvm.func spir_funccc @_Z8prefetchPU3AS1Kcm(!llvm.ptr<1>, i64) attributes
-// CHECK-SAME: {memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none>, no_unwind}
+// CHECK-SAME: {memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none, errnoMem = none, targetMem0 = none, targetMem1 = none>, no_unwind}
// CHECK: llvm.func @prefetch(%[[ARG0:.*]]: !llvm.ptr<1>) {
llvm.func @prefetch(%ptr: !llvm.ptr<1>) {
// CHECK: %[[VAR0:.*]] = llvm.mlir.constant(1 : i64) : i64
// CHECK: llvm.call spir_funccc @_Z8prefetchPU3AS1Kcm(%[[ARG0]], %[[VAR0]])
// CHECK-SAME: {function_type = !llvm.func<void (ptr<1>, i64)>, linkage = #llvm.linkage<external>,
- // CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibleMem = none>,
+ // CHECK-SAME: memory_effects = #llvm.memory_effects<other = none, argMem = read, inaccessibl...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/168568
More information about the cfe-commits
mailing list