[clang] [llvm] [HLSL][SPIR-V] Implement vk::push_constant (PR #166793)
Steven Perron via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 10 10:21:00 PST 2025
================
@@ -3846,6 +3851,7 @@ static bool IsDefaultBufferConstantDecl(VarDecl *VD) {
QT.getAddressSpace() == LangAS::Default &&
VD->getStorageClass() != SC_Static &&
!VD->hasAttr<HLSLVkConstantIdAttr>() &&
+ !VD->hasAttr<HLSLVkPushConstantAttr>() &&
----------------
s-perron wrote:
I think this is where we should be ignoring the `vk::push_constant` attribuute if we are not targeting spir-v.
We might need to fix up the `vk:constant_id` attribute as well, but that is not your problem.
https://github.com/llvm/llvm-project/pull/166793
More information about the cfe-commits
mailing list