[clang] [CIR] X86 vector fcmp-sse vector builtins (PR #167125)
Andy Kaylor via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 10 10:09:50 PST 2025
================
@@ -21,18 +21,18 @@
using namespace clang;
using namespace clang::CIRGen;
-mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
- const CallExpr *e) {
- if (builtinID == Builtin::BI__builtin_cpu_is) {
- cgm.errorNYI(e->getSourceRange(), "__builtin_cpu_is");
+mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned BuiltinID,
----------------
andykaylor wrote:
Yes, Amr is correct. The style used in CIR varies depending on the directory. The rules we have agreed on are documented here: https://llvm.github.io/clangir/GettingStarted/coding-guideline.html#variable-naming-camelcase-vs-camelback
Those rules aren't consistently followed in the incubator because most of the incubator code was developed before the agreement was made, but the code should be updated as it is upstreamed. In this directory, we follow MLIR coding style, so variables use `camelCase` with a lowercase leading letter.
https://github.com/llvm/llvm-project/pull/167125
More information about the cfe-commits
mailing list