[clang] [CIR] Fix failing lit test (statement-exprs.c) (PR #167000)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 7 11:32:43 PST 2025


https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/167000

This fixes a test case in the clang/CIR/CodeGen/statement-exprs.c test. The test case was copied from a similar test in clang/CodeGen/exprs.c and was recently broken by https://github.com/llvm/llvm-project/pull/166036 which corrects Clang's behavior with trailing NullStmts. This change updates the CIR test in the same way that the classic codegen test was updated, removing the trailing null part of the expression.

>From 548256f10ba00e0d9762259aab4d64566458af48 Mon Sep 17 00:00:00 2001
From: Andy Kaylor <akaylor at nvidia.com>
Date: Fri, 7 Nov 2025 11:27:50 -0800
Subject: [PATCH] [CIR] Fix failing lit test (statement-exprs.c)

This fixes a test case in the clang/CIR/CodeGen/statement-exprs.c test. The
test case was copied from a similar test in clang/CodeGen/exprs.c and was
recently broken by https://github.com/llvm/llvm-project/pull/166036 which
corrects Clang's behavior with trailing NullStmts. This change updates
the CIR test in the same way that the classic codegen test was updated,
removing the trailing null part of the expression.
---
 clang/test/CIR/CodeGen/statement-exprs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/test/CIR/CodeGen/statement-exprs.c b/clang/test/CIR/CodeGen/statement-exprs.c
index c784ec9eda7d8..5925515997270 100644
--- a/clang/test/CIR/CodeGen/statement-exprs.c
+++ b/clang/test/CIR/CodeGen/statement-exprs.c
@@ -6,7 +6,7 @@
 // RUN: FileCheck --input-file=%t.ll %s --check-prefix=OGCG
 
 int f19(void) {
-  return ({ 3;;4;; });
+  return ({ 3;;4; });
 }
 
 // CIR: cir.func dso_local @f19() -> !s32i



More information about the cfe-commits mailing list