[clang] [Sema] Suggest missing format attributes (PR #166738)

[via cfe-commits]

================
@@ -6517,7 +6517,8 @@ static StringLiteralCheckType checkFormatStringExpr(
     unsigned format_idx, unsigned firstDataArg, FormatStringType Type,
     VariadicCallType CallType, bool InFunctionCall,
     llvm::SmallBitVector &CheckedVarArgs, UncoveredArgHandler &UncoveredArg,
-    llvm::APSInt Offset, bool IgnoreStringsWithoutSpecifiers = false) {
+    llvm::APSInt Offset, std::optional<unsigned> *CallerParamIdx = nullptr,
----------------
apple-fcloutier wrote:

`CallerParamIdx` could mean anything. `CallerFormatParamIdx` is a little bit longer but a lot more clear, IMO.

https://github.com/llvm/llvm-project/pull/166738