[clang] [clang][SourceManager] Reuse code when computing Column and Line numbers (PR #166593)

via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 5 09:09:22 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManager.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/Basic/SourceManager.h b/clang/include/clang/Basic/SourceManager.h
index 6b7daebb3..bc9e97863 100644
--- a/clang/include/clang/Basic/SourceManager.h
+++ b/clang/include/clang/Basic/SourceManager.h
@@ -1429,10 +1429,12 @@ public:
   /// diagnostic.
   unsigned getLineNumber(FileID FID, unsigned FilePos, bool *Invalid = nullptr) const;
   unsigned getLineNumber(SourceLocation Loc, bool *Invalid = nullptr) const;
-  unsigned getSpellingLineNumber(SourceLocation Loc, bool *Invalid = nullptr) const {
+  unsigned getSpellingLineNumber(SourceLocation Loc,
+                                 bool *Invalid = nullptr) const {
     return getLineNumber(getSpellingLoc(Loc), Invalid);
   }
-  unsigned getExpansionLineNumber(SourceLocation Loc, bool *Invalid = nullptr) const {
+  unsigned getExpansionLineNumber(SourceLocation Loc,
+                                  bool *Invalid = nullptr) const {
     return getLineNumber(getExpansionLoc(Loc), Invalid);
   }
   unsigned getPresumedLineNumber(SourceLocation Loc, bool *Invalid = nullptr) const;

``````````

</details>


https://github.com/llvm/llvm-project/pull/166593


More information about the cfe-commits mailing list