[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

[via cfe-commits]

Sirraide wrote:

> > The possible redundancy between `CXXBindTemporaryExpr` and `VarDecl` with a destructor is tricky. Most of the time temporaries seem to be orthogonal to `VarDecls` -- it's clearly not as simple as removing the check on `VarDecl`
> 
> Can we simply keep both checks? Or does that cause too many duplicate diagnostics?

Alternatively, can we skip checking the type of the `VarDecl` if the initialiser is a `CXXBindTemporaryExpr`?

https://github.com/llvm/llvm-project/pull/166110