[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

[Doug Wyatt via cfe-commits]

dougsonos wrote:

Added that as test `nb24()`, thanks.

The possible redundancy between `CXXBindTemporaryExpr` and `VarDecl` with a destructor is tricky. Most of the time temporaries seem to be orthogonal to `VarDecls` -- it's clearly not as simple as removing the check on `VarDecl`.

https://github.com/llvm/llvm-project/pull/166110