[clang] [clang] Adjust TextDiagnostic style ranges for interesting source region (PR #164941)

via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 31 08:14:34 PDT 2025


Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/164941 at github.com>


================
@@ -1508,8 +1544,9 @@ void TextDiagnostic::emitSnippet(StringRef SourceLine,
   // Print the source line one character at a time.
   bool PrintReversed = false;
   std::optional<llvm::raw_ostream::Colors> CurrentColor;
-  size_t I = 0;
+  size_t I = 0; // Bytes.
----------------
Sirraide wrote:

I see; we might want to update it to use Bytes/Columns too, but that’s a separate matter, so this here can stay as-is for now.

https://github.com/llvm/llvm-project/pull/164941


More information about the cfe-commits mailing list