[clang] [analyzer] Revert incorrect LazyCoumpoundVal changes (PR #163461)

[Marco Borgeaud via cfe-commits]

================
@@ -4,16 +4,6 @@
 // RUN:  -analyzer-config alpha.cplusplus.STLAlgorithmModeling:AggressiveStdFindModeling=true\
 // RUN:  -verify
 
-// STLAlgorithmModeling and DebugIteratorModeling are probably bugged because
-// these tests started failing after we just directly copy the symbol
-// representing the value of a variable instead of creating a LazyCompoundVal
-// of that single conjured value.
-// In theory, it shouldn't matter if we eagerly copy the value that we would
-// "load" from the LCV once requested or just directly binding the backing symbol.
-// Yet, these tests fail, so there is likely messed up how/what the checker
-// metadata is associated with.
-// XFAIL: *
----------------
marco-antognini-sonarsource wrote:

In a way, it is comforting to know we are aligned on the short term strategy. :-) 

https://github.com/llvm/llvm-project/pull/163461