[clang] [clang] Add Bytes/Column types to TextDiagnostic (PR #165541)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 29 05:01:06 PDT 2025
================
@@ -390,70 +448,72 @@ static void selectInterestingSourceRegion(std::string &SourceLine,
// number of columns we have, try to grow the slice to encompass
// more context.
- unsigned SourceStart = map.columnToByte(std::min<unsigned>(CaretStart,
- map.columns()));
- unsigned SourceEnd = map.columnToByte(std::min<unsigned>(CaretEnd,
- map.columns()));
+ Bytes SourceStart =
+ map.columnToByte(Columns(std::min<int>(CaretStart.V, map.columns().V)));
+ Bytes SourceEnd =
+ map.columnToByte(Columns(std::min<int>(CaretEnd.V, map.columns().V)));
----------------
Sirraide wrote:
```suggestion
Bytes SourceStart = map.columnToByte(std::min(CaretStart, map.columns()));
Bytes SourceEnd = map.columnToByte(std::min(CaretEnd, map.columns()));
```
https://github.com/llvm/llvm-project/pull/165541
More information about the cfe-commits
mailing list