[clang-tools-extra] [clang-tidy][NFC] Fix various clang-tidy warning on headers 1/N (PR #165175)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 26 15:07:37 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-tools-extra
Author: Baranov Victor (vbvictor)
<details>
<summary>Changes</summary>
Started running `clang-tidy` on our clang-tidy headers. This part covers what `clang-tidy` could fix automatically (with `--fix` option).
The main goal is to enable `HeaderFilterRegex: 'clang-tools-extra/clang-tidy/.*'` eventually in config.
---
Patch is 32.30 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/165175.diff
36 Files Affected:
- (modified) clang-tools-extra/clang-tidy/ClangTidyModule.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/ClangTidyOptions.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationRewriter.h (+5-5)
- (modified) clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/android/CloexecCheck.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp (+4-4)
- (modified) clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h (+4-4)
- (modified) clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h (+2-2)
- (modified) clang-tools-extra/clang-tidy/google/TodoCommentCheck.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp (+3-3)
- (modified) clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/performance/NoexceptDestructorCheck.h (+2-3)
- (modified) clang-tools-extra/clang-tidy/performance/NoexceptFunctionBaseCheck.h (+1-2)
- (modified) clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.h (+2-3)
- (modified) clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.h (+2-3)
- (modified) clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.h (-1)
- (modified) clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/utils/BracesAroundStatement.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp (+2-3)
- (modified) clang-tools-extra/clang-tidy/utils/IncludeSorter.h (+2-2)
- (modified) clang-tools-extra/clang-tidy/utils/Matchers.h (+1-1)
- (modified) clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h (+1-1)
- (modified) clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h (+6-8)
``````````diff
diff --git a/clang-tools-extra/clang-tidy/ClangTidyModule.h b/clang-tools-extra/clang-tidy/ClangTidyModule.h
index 8d697c6261286..53ef3f153dd15 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyModule.h
+++ b/clang-tools-extra/clang-tidy/ClangTidyModule.h
@@ -85,7 +85,7 @@ class ClangTidyCheckFactories {
/// them a prefixed name.
class ClangTidyModule {
public:
- virtual ~ClangTidyModule() {}
+ virtual ~ClangTidyModule() = default;
/// Implement this function in order to register all \c CheckFactories
/// belonging to this module.
diff --git a/clang-tools-extra/clang-tidy/ClangTidyOptions.h b/clang-tools-extra/clang-tidy/ClangTidyOptions.h
index 2aae92f1d9eb3..4c97c5ba801f0 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyOptions.h
+++ b/clang-tools-extra/clang-tidy/ClangTidyOptions.h
@@ -171,7 +171,7 @@ class ClangTidyOptionsProvider {
static const char OptionsSourceTypeCheckCommandLineOption[];
static const char OptionsSourceTypeConfigCommandLineOption[];
- virtual ~ClangTidyOptionsProvider() {}
+ virtual ~ClangTidyOptionsProvider() = default;
/// Returns global options, which are independent of the file.
virtual const ClangTidyGlobalOptions &getGlobalOptions() = 0;
diff --git a/clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h b/clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h
index e599bda92c25c..aaa04107a11ec 100644
--- a/clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h
+++ b/clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h
@@ -44,7 +44,7 @@ class ExpandModularHeadersPPCallbacks : public PPCallbacks {
ExpandModularHeadersPPCallbacks(
CompilerInstance *CI,
IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS);
- ~ExpandModularHeadersPPCallbacks();
+ ~ExpandModularHeadersPPCallbacks() override;
/// Returns the preprocessor that provides callbacks for the whole
/// translation unit, including the main file, textual headers, and modular
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.cpp
index 4e1bd3ae32ee5..03f78f1c96252 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/DurationAdditionCheck.cpp
@@ -21,7 +21,7 @@ void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
binaryOperator(hasOperatorName("+"),
hasEitherOperand(expr(ignoringParenImpCasts(
- callExpr(callee(functionDecl(TimeConversionFunction())
+ callExpr(callee(functionDecl(timeConversionFunction())
.bind("function_decl")))
.bind("call")))))
.bind("binop"),
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp
index cb8a478e288b6..16a244b7e9997 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp
@@ -17,7 +17,7 @@ namespace clang::tidy::abseil {
void DurationComparisonCheck::registerMatchers(MatchFinder *Finder) {
auto Matcher = expr(comparisonOperatorWithCallee(functionDecl(
- functionDecl(DurationConversionFunction())
+ functionDecl(durationConversionFunction())
.bind("function_decl"))))
.bind("binop");
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp
index cf591d9589057..11d6017c22e9d 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp
@@ -19,7 +19,7 @@ namespace clang::tidy::abseil {
void DurationConversionCastCheck::registerMatchers(MatchFinder *Finder) {
auto CallMatcher = ignoringImpCasts(callExpr(
- callee(functionDecl(DurationConversionFunction()).bind("func_decl")),
+ callee(functionDecl(durationConversionFunction()).bind("func_decl")),
hasArgument(0, expr().bind("arg"))));
Finder->addMatcher(
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp
index cccd7cf796150..83906fe05054f 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp
@@ -28,7 +28,7 @@ static bool insideMacroDefinition(const MatchFinder::MatchResult &Result,
void DurationFactoryFloatCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
- callExpr(callee(functionDecl(DurationFactoryFunction())),
+ callExpr(callee(functionDecl(durationFactoryFunction())),
hasArgument(0, anyOf(cxxStaticCastExpr(hasDestinationType(
realFloatingPointType())),
cStyleCastExpr(hasDestinationType(
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp
index 1d6ff1ab17abd..334629767aff2 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp
@@ -112,7 +112,7 @@ static std::optional<DurationScale> getNewScale(DurationScale OldScale,
void DurationFactoryScaleCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
callExpr(
- callee(functionDecl(DurationFactoryFunction()).bind("call_decl")),
+ callee(functionDecl(durationFactoryFunction()).bind("call_decl")),
hasArgument(
0,
ignoringImpCasts(anyOf(
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationRewriter.h b/clang-tools-extra/clang-tidy/abseil/DurationRewriter.h
index 27d6ca0616985..e3b1753e95a16 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationRewriter.h
+++ b/clang-tools-extra/clang-tidy/abseil/DurationRewriter.h
@@ -96,7 +96,7 @@ bool isInMacro(const ast_matchers::MatchFinder::MatchResult &Result,
const Expr *E);
AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
- DurationConversionFunction) {
+ durationConversionFunction) {
using namespace clang::ast_matchers;
return functionDecl(
hasAnyName("::absl::ToDoubleHours", "::absl::ToDoubleMinutes",
@@ -108,7 +108,7 @@ AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
}
AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
- DurationFactoryFunction) {
+ durationFactoryFunction) {
using namespace clang::ast_matchers;
return functionDecl(hasAnyName("::absl::Nanoseconds", "::absl::Microseconds",
"::absl::Milliseconds", "::absl::Seconds",
@@ -116,7 +116,7 @@ AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
}
AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
- TimeConversionFunction) {
+ timeConversionFunction) {
using namespace clang::ast_matchers;
return functionDecl(hasAnyName(
"::absl::ToUnixHours", "::absl::ToUnixMinutes", "::absl::ToUnixSeconds",
@@ -125,12 +125,12 @@ AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
AST_MATCHER_FUNCTION_P(ast_matchers::internal::Matcher<Stmt>,
comparisonOperatorWithCallee,
- ast_matchers::internal::Matcher<Decl>, funcDecl) {
+ ast_matchers::internal::Matcher<Decl>, FuncDecl) {
using namespace clang::ast_matchers;
return binaryOperator(
anyOf(hasOperatorName(">"), hasOperatorName(">="), hasOperatorName("=="),
hasOperatorName("<="), hasOperatorName("<")),
- hasEitherOperand(ignoringImpCasts(callExpr(callee(funcDecl)))));
+ hasEitherOperand(ignoringImpCasts(callExpr(callee(FuncDecl)))));
}
} // namespace clang::tidy::abseil
diff --git a/clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.cpp
index fd5e2038f75d1..c5d93ad51ad17 100644
--- a/clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/DurationSubtractionCheck.cpp
@@ -21,7 +21,7 @@ void DurationSubtractionCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
binaryOperator(
hasOperatorName("-"),
- hasLHS(callExpr(callee(functionDecl(DurationConversionFunction())
+ hasLHS(callExpr(callee(functionDecl(durationConversionFunction())
.bind("function_decl")),
hasArgument(0, expr().bind("lhs_arg")))))
.bind("binop"),
diff --git a/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp b/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp
index 52121a57de0d1..7a97a1895ad02 100644
--- a/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp
@@ -18,7 +18,7 @@ namespace clang::tidy::abseil {
void TimeComparisonCheck::registerMatchers(MatchFinder *Finder) {
auto Matcher =
expr(comparisonOperatorWithCallee(functionDecl(
- functionDecl(TimeConversionFunction()).bind("function_decl"))))
+ functionDecl(timeConversionFunction()).bind("function_decl"))))
.bind("binop");
Finder->addMatcher(Matcher, this);
diff --git a/clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp b/clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp
index f7905e081170e..8b197e5b939e7 100644
--- a/clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp
@@ -104,7 +104,7 @@ void UpgradeDurationConversionsCheck::registerMatchers(MatchFinder *Finder) {
hasCastKind(CK_UserDefinedConversion)))),
hasParent(callExpr(
callee(functionDecl(
- DurationFactoryFunction(),
+ durationFactoryFunction(),
unless(hasParent(functionTemplateDecl())))),
hasArgument(0, expr().bind("arg")))))
.bind("OuterExpr")),
diff --git a/clang-tools-extra/clang-tidy/android/CloexecCheck.h b/clang-tools-extra/clang-tidy/android/CloexecCheck.h
index b2b59f5be1b9a..858d96ab45b61 100644
--- a/clang-tools-extra/clang-tidy/android/CloexecCheck.h
+++ b/clang-tools-extra/clang-tidy/android/CloexecCheck.h
@@ -82,7 +82,7 @@ class CloexecCheck : public ClangTidyCheck {
/// \param Mode The required mode char.
/// \param ArgPos The 0-based position of the flag argument.
void insertStringFlag(const ast_matchers::MatchFinder::MatchResult &Result,
- const char Mode, const int ArgPos);
+ char Mode, int ArgPos);
/// Helper function to get the spelling of a particular argument.
StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult &Result,
diff --git a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
index 9c05827556e67..9631c71dee64e 100644
--- a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
+++ b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
@@ -41,7 +41,7 @@ class NarrowingConversionsCheck : public ClangTidyCheck {
void diagNarrowIntegerConstantToSignedInt(SourceLocation SourceLoc,
const Expr &Lhs, const Expr &Rhs,
const llvm::APSInt &Value,
- const uint64_t HexBits);
+ uint64_t HexBits);
void diagNarrowConstant(SourceLocation SourceLoc, const Expr &Lhs,
const Expr &Rhs);
diff --git a/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
index ca85168ffce0b..08fae7b59bae5 100644
--- a/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
@@ -823,7 +823,7 @@ void NotNullTerminatedResultCheck::check(
if (Name.starts_with("mem") || Name.starts_with("wmem"))
memoryHandlerFunctionFix(Name, Result);
else if (Name == "strerror_s")
- strerror_sFix(Result);
+ strerrorSFix(Result);
else if (Name.ends_with("ncmp"))
ncmpFix(Name, Result);
else if (Name.ends_with("xfrm"))
@@ -852,7 +852,7 @@ void NotNullTerminatedResultCheck::memoryHandlerFunctionFix(
if (Name.ends_with("cpy")) {
memcpyFix(Name, Result, Diag);
} else if (Name.ends_with("cpy_s")) {
- memcpy_sFix(Name, Result, Diag);
+ memcpySFix(Name, Result, Diag);
} else if (Name.ends_with("move")) {
memmoveFix(Name, Result, Diag);
} else if (Name.ends_with("move_s")) {
@@ -889,7 +889,7 @@ void NotNullTerminatedResultCheck::memcpyFix(
insertNullTerminatorExpr(Name, Result, Diag);
}
-void NotNullTerminatedResultCheck::memcpy_sFix(
+void NotNullTerminatedResultCheck::memcpySFix(
StringRef Name, const MatchFinder::MatchResult &Result,
DiagnosticBuilder &Diag) {
bool IsOverflows = isDestCapacityFix(Result, Diag);
@@ -950,7 +950,7 @@ void NotNullTerminatedResultCheck::memmoveFix(
lengthArgHandle(LengthHandleKind::Increase, Result, Diag);
}
-void NotNullTerminatedResultCheck::strerror_sFix(
+void NotNullTerminatedResultCheck::strerrorSFix(
const MatchFinder::MatchResult &Result) {
auto Diag =
diag(Result.Nodes.getNodeAs<CallExpr>(FunctionExprName)->getBeginLoc(),
diff --git a/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h b/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h
index ca3fbf0febf7a..a8f4ca32a0b5b 100644
--- a/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h
+++ b/clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h
@@ -43,15 +43,15 @@ class NotNullTerminatedResultCheck : public ClangTidyCheck {
void memcpyFix(StringRef Name,
const ast_matchers::MatchFinder::MatchResult &Result,
DiagnosticBuilder &Diag);
- void memcpy_sFix(StringRef Name,
- const ast_matchers::MatchFinder::MatchResult &Result,
- DiagnosticBuilder &Diag);
+ void memcpySFix(StringRef Name,
+ const ast_matchers::MatchFinder::MatchResult &Result,
+ DiagnosticBuilder &Diag);
void memchrFix(StringRef Name,
const ast_matchers::MatchFinder::MatchResult &Result);
void memmoveFix(StringRef Name,
const ast_matchers::MatchFinder::MatchResult &Result,
DiagnosticBuilder &Diag) const;
- void strerror_sFix(const ast_matchers::MatchFinder::MatchResult &Result);
+ void strerrorSFix(const ast_matchers::MatchFinder::MatchResult &Result);
void ncmpFix(StringRef Name,
const ast_matchers::MatchFinder::MatchResult &Result);
void xfrmFix(StringRef Name,
diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h b/clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
index 8cdaf315eac52..507aaa1cb9d79 100644
--- a/clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
+++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
@@ -84,11 +84,11 @@ struct DenseMapInfo<
using ClassDefId =
clang::tidy::cppcoreguidelines::SpecialMemberFunctionsCheck::ClassDefId;
- static inline ClassDefId getEmptyKey() {
+ static ClassDefId getEmptyKey() {
return {DenseMapInfo<clang::SourceLocation>::getEmptyKey(), "EMPTY"};
}
- static inline ClassDefId getTombstoneKey() {
+ static ClassDefId getTombstoneKey() {
return {DenseMapInfo<clang::SourceLocation>::getTombstoneKey(),
"TOMBSTONE"};
}
diff --git a/clang-tools-extra/clang-tidy/google/TodoCommentCheck.h b/clang-tools-extra/clang-tidy/google/TodoCommentCheck.h
index 05f9cc6618eb1..08cea131ec44d 100644
--- a/clang-tools-extra/clang-tidy/google/TodoCommentCheck.h
+++ b/clang-tools-extra/clang-tidy/google/TodoCommentCheck.h
@@ -22,7 +22,7 @@ namespace clang::tidy::google::readability {
class TodoCommentCheck : public ClangTidyCheck {
public:
TodoCommentCheck(StringRef Name, ClangTidyContext *Context);
- ~TodoCommentCheck();
+ ~TodoCommentCheck() override;
void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
Preprocessor *ModuleExpanderPP) override;
diff --git a/clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.h b/clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.h
index 37337954822b7..b341d03083c92 100644
--- a/clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.h
+++ b/clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.h
@@ -21,7 +21,7 @@ namespace clang::tidy::misc {
class ConfusableIdentifierCheck : public ClangTidyCheck {
public:
ConfusableIdentifierCheck(StringRef Name, ClangTidyContext *Context);
- ~ConfusableIdentifierCheck();
+ ~ConfusableIdentifierCheck() override;
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h
index aa7e0432b9ceb..ba895b95b9a25 100644
--- a/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h
+++ b/clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.h
@@ -16,7 +16,7 @@ namespace clang::tidy::misc {
class MisleadingBidirectionalCheck : public ClangTidyCheck {
public:
MisleadingBidirectionalCheck(StringRef Name, ClangTidyContext *Context);
- ~MisleadingBidirectionalCheck();
+ ~MisleadingBidirectionalCheck() override;
void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP,
Preprocessor *ModuleExpanderPP) override;
diff --git a/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h b/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h
index 5e1a56ddc479a..06b83d567a9d2 100644
--- a/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h
+++ b/clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h
@@ -16,7 +16,7 @@ namespace clang::tidy::misc {
class MisleadingIdentifierCheck : public ClangTidyCheck {
public:
MisleadingIdentifierCheck(StringRef Name, ClangTidyContext *Context);
- ~MisleadingIdentifierCheck();
+ ~MisleadingIdentifierCheck() override;
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
diff --git a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.h b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.h
index 6e09086d667f9..877fc4d6503d6 100644
--- a/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.h
+++ b/clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.h
@@ -18,7 +18,7 @@ namespace clang::tidy::misc {
class UnusedParametersCheck : public ClangTidyCheck {
public:
UnusedParametersCheck(StringRef Name, ClangTidyContext *Context);
- ~UnusedParametersCheck();
+ ~UnusedParametersCheck() override;
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
diff --git a/clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp b/clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
index 586deea46e86f..6fb780844f2b6 100644
--- a/clang-tools-extra/clang-tidy/modernize/LoopConvertUt...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/165175
More information about the cfe-commits
mailing list