[clang] [Clang] Drop Shell Requirements (PR #165149)

Aiden Grossman via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 26 01:42:58 PDT 2025


https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/165149

These are basically synonymous with marking windows as an unsupported platform at this point and should be removed in favor of such annotations. Removing the remianing annotations which should further unblock removing the feature altogether now that everything minus compiler-rt is using the internal shell by default. These were missed when making the tests compatible with the internal shell.

>From 8b23c143db457ae7a1a803b1bdc4249840ef774c Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Sun, 26 Oct 2025 08:40:24 +0000
Subject: [PATCH] [Clang] Drop Shell Requirements

These are basically synonymous with marking windows as an unsupported
platform at this point and should be removed in favor of such
annotations. Removing the remianing annotations which should further
unblock removing the feature altogether now that everything minus
compiler-rt is using the internal shell by default.
---
 clang/test/ClangScanDeps/resource_directory.c          | 2 --
 clang/test/Driver/baremetal-multilib-custom-error.yaml | 1 -
 clang/test/Frontend/absolute-paths-symlinks.c          | 1 -
 clang/test/Tooling/clang-check-pwd.cpp                 | 2 --
 4 files changed, 6 deletions(-)

diff --git a/clang/test/ClangScanDeps/resource_directory.c b/clang/test/ClangScanDeps/resource_directory.c
index 6183e8aefacfa..e86f28e77e7c3 100644
--- a/clang/test/ClangScanDeps/resource_directory.c
+++ b/clang/test/ClangScanDeps/resource_directory.c
@@ -1,5 +1,3 @@
-// REQUIRES: shell
-
 // RUN: rm -rf %t && mkdir %t
 // RUN: cp %S/Inputs/resource_directory/* %t
 
diff --git a/clang/test/Driver/baremetal-multilib-custom-error.yaml b/clang/test/Driver/baremetal-multilib-custom-error.yaml
index 0be92e26aae28..bc06ed468572c 100644
--- a/clang/test/Driver/baremetal-multilib-custom-error.yaml
+++ b/clang/test/Driver/baremetal-multilib-custom-error.yaml
@@ -1,4 +1,3 @@
-# REQUIRES: shell
 # UNSUPPORTED: system-windows
 
 # RUN: %clang --multi-lib-config=%s -no-canonical-prefixes -print-multi-directory 2>&1 \
diff --git a/clang/test/Frontend/absolute-paths-symlinks.c b/clang/test/Frontend/absolute-paths-symlinks.c
index 8170910b6f6ec..80bca34eb9d4b 100644
--- a/clang/test/Frontend/absolute-paths-symlinks.c
+++ b/clang/test/Frontend/absolute-paths-symlinks.c
@@ -12,6 +12,5 @@
 // CHECK-SAME: error: unknown type name
 This do not compile
 
-// REQUIRES: shell
 // Don't make symlinks on Windows.
 // UNSUPPORTED: system-windows
diff --git a/clang/test/Tooling/clang-check-pwd.cpp b/clang/test/Tooling/clang-check-pwd.cpp
index 309cee54aadd9..e4360c006cd16 100644
--- a/clang/test/Tooling/clang-check-pwd.cpp
+++ b/clang/test/Tooling/clang-check-pwd.cpp
@@ -12,5 +12,3 @@
 // CHECK: a type specifier is required
 // CHECK: .foobar/test.cpp
 invalid;
-
-// REQUIRES: shell



More information about the cfe-commits mailing list