[clang] e101afc - [CIR][NFC] Fix maybe_unused build issues (#163997)

[via cfe-commits]

Author: Andy Kaylor
Date: 2025-10-17T13:34:15-07:00
New Revision: e101afc595d9cf7bd006ff610cbbf815f2a2ad05

URL: https://github.com/llvm/llvm-project/commit/e101afc595d9cf7bd006ff610cbbf815f2a2ad05
DIFF: https://github.com/llvm/llvm-project/commit/e101afc595d9cf7bd006ff610cbbf815f2a2ad05.diff

LOG: [CIR][NFC] Fix maybe_unused build issues (#163997)

This fixes a build failure that occurs with some versions of clang.
There was a problem in clang, which has been fixed in more recent
versions, where mixing GNU-style attributes with C++-style attributes
caused a failure. A recent code change updated a few uses of
`LLVM_ATTRIBUTE_UNUSED` to `[[maybe_unused]]`, triggering this problem.

This change reorders the attributes in a way that avoids the issue.

Added: 
    

Modified: 
    clang/lib/CIR/CodeGen/CIRGenValue.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/CIR/CodeGen/CIRGenValue.h b/clang/lib/CIR/CodeGen/CIRGenValue.h
index 08d9913c09c38..c05142e9853ba 100644
--- a/clang/lib/CIR/CodeGen/CIRGenValue.h
+++ b/clang/lib/CIR/CodeGen/CIRGenValue.h
@@ -307,8 +307,8 @@ class AggValueSlot {
   /// This is set to true if some external code is responsible for setting up a
   /// destructor for the slot.  Otherwise the code which constructs it should
   /// push the appropriate cleanup.
-  LLVM_PREFERRED_TYPE(bool)
-  [[maybe_unused]] unsigned destructedFlag : 1;
+  [[maybe_unused]]
+  LLVM_PREFERRED_TYPE(bool) unsigned destructedFlag : 1;
 
   /// This is set to true if the memory in the slot is known to be zero before
   /// the assignment into it.  This means that zero fields don't need to be set.
@@ -326,16 +326,16 @@ class AggValueSlot {
   /// over.  Since it's invalid in general to memcpy a non-POD C++
   /// object, it's important that this flag never be set when
   /// evaluating an expression which constructs such an object.
-  LLVM_PREFERRED_TYPE(bool)
-  [[maybe_unused]] unsigned aliasedFlag : 1;
+  [[maybe_unused]]
+  LLVM_PREFERRED_TYPE(bool) unsigned aliasedFlag : 1;
 
   /// This is set to true if the tail padding of this slot might overlap
   /// another object that may have already been initialized (and whose
   /// value must be preserved by this initialization). If so, we may only
   /// store up to the dsize of the type. Otherwise we can widen stores to
   /// the size of the type.
-  LLVM_PREFERRED_TYPE(bool)
-  [[maybe_unused]] unsigned overlapFlag : 1;
+  [[maybe_unused]]
+  LLVM_PREFERRED_TYPE(bool) unsigned overlapFlag : 1;
 
 public:
   enum IsDestructed_t { IsNotDestructed, IsDestructed };