[clang] [Clang][Sema] Fix err_constexpr_virtual_base diagnostic so that it only diagnoses on constructors and destructors (PR #163690)
Corentin Jabot via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 15 22:51:50 PDT 2025
================
@@ -1918,23 +1918,22 @@ static bool CheckConstexprMissingReturn(Sema &SemaRef, const FunctionDecl *Dcl);
bool Sema::CheckConstexprFunctionDefinition(const FunctionDecl *NewFD,
CheckConstexprKind Kind) {
- const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(NewFD);
- if (MD && MD->isInstance()) {
+ if ((!getLangOpts().CPlusPlus26 && isa<CXXConstructorDecl>(NewFD)) ||
+ ((getLangOpts().CPlusPlus20 && !getLangOpts().CPlusPlus26) &&
+ isa<CXXDestructorDecl>(NewFD))) {
+ const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(NewFD);
----------------
cor3ntin wrote:
This feels like you are trying to partially implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3533r2.html as a drive-by?
https://github.com/llvm/llvm-project/pull/163690
More information about the cfe-commits
mailing list