[clang] [HLSL] Allow input semantics on structs (PR #159047)

[Chris B via cfe-commits]

Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/159047 at github.com>


================
@@ -1,7 +1,9 @@
 // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-pixel -x hlsl -finclude-default-header -o - %s -ast-dump | FileCheck %s
 
-float4 main(float4 a : SV_Position) {
+float4 main(float4 a : SV_Position2) {
----------------
llvm-beanz wrote:

This code is technically invalid right? It should require a semantic on the return type.

Since this is an area you're actively working on I think it is fine to have a test that includes invalid code, but we should put a comment in the test identifying that it is invalid and maybe link to an issue that will resolve it so that we can associate the fix correctly.

https://github.com/llvm/llvm-project/pull/159047