[clang] [Clang] Add __builtin_bswapg (PR #162433)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 14 23:57:00 PDT 2025
https://github.com/clingfei updated https://github.com/llvm/llvm-project/pull/162433
>From 92466f3789ce1849ebee8a405efd42e191c591f5 Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Wed, 8 Oct 2025 15:05:44 +0800
Subject: [PATCH 1/7] [Clang] Add __builtin_bswapg
---
clang/include/clang/Basic/Builtins.td | 6 ++++
clang/lib/AST/ByteCode/InterpBuiltin.cpp | 10 ++++++-
clang/lib/AST/ExprConstant.cpp | 11 ++++++++
clang/lib/CodeGen/CGBuiltin.cpp | 1 +
clang/lib/Sema/SemaChecking.cpp | 28 +++++++++++++++++++
clang/test/AST/ByteCode/builtin-functions.cpp | 4 +++
clang/test/CodeGen/builtins.c | 2 +-
clang/test/Sema/constant-builtins-2.c | 4 +++
clang/test/Sema/constant-builtins.c | 5 +++-
9 files changed, 68 insertions(+), 3 deletions(-)
diff --git a/clang/include/clang/Basic/Builtins.td b/clang/include/clang/Basic/Builtins.td
index 468121f7d20ab..e65ed2f20be97 100644
--- a/clang/include/clang/Basic/Builtins.td
+++ b/clang/include/clang/Basic/Builtins.td
@@ -755,6 +755,12 @@ def BSwap : Builtin, Template<["unsigned short", "uint32_t", "uint64_t"],
let Prototype = "T(T)";
}
+def BSwapg : Builtin {
+ let Spellings = ["__builtin_bswapg"];
+ let Attributes = [NoThrow, Const, Constexpr, CustomTypeChecking];
+ let Prototype = "int(...)";
+}
+
def Bitreverse : BitInt8_16_32_64BuiltinsTemplate, Builtin {
let Spellings = ["__builtin_bitreverse"];
let Attributes = [NoThrow, Const, Constexpr];
diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index 1eea813b8c556..b8d17fbce6d4e 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -3288,7 +3288,15 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
case Builtin::BI__builtin_elementwise_ctzg:
return interp__builtin_elementwise_countzeroes(S, OpPC, Frame, Call,
BuiltinID);
-
+ case Builtin::BI__builtin_bswapg: {
+ const APSInt &Val = popToAPSInt(S, Call->getArg(0));
+ assert(Val.getActiveBits() <= 64);
+ if (Val.getBitWidth() == 8)
+ pushInteger(S, Val, Call->getType());
+ else
+ pushInteger(S, Val.byteSwap(), Call->getType());
+ return true;
+ }
case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32:
case Builtin::BI__builtin_bswap64:
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 618e1636e9e53..058905e7fd3c0 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -13982,6 +13982,17 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
return Success(Val.reverseBits(), E);
}
+ case Builtin::BI__builtin_bswapg: {
+ APSInt Val;
+ if (!EvaluateInteger(E->getArg(0), Val, Info))
+ return false;
+ if (Val.getBitWidth() == 8) {
+ bool ret = Success(Val, E);
+ return ret;
+ }
+
+ return Success(Val.byteSwap(), E);
+ }
case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32:
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 9ee810c9d5775..7733f4dc15f5d 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -3622,6 +3622,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType)));
return RValue::get(ArgValue);
}
+ case Builtin::BI__builtin_bswapg:
case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32:
case Builtin::BI__builtin_bswap64:
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 063db05665af1..362b53676feaa 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -2200,6 +2200,30 @@ static bool BuiltinCpu(Sema &S, const TargetInfo &TI, CallExpr *TheCall,
return false;
}
+/// Checks that __builtin_bswapg was called with a single argument, which is an
+/// unsigned integer, and overrides the return value type to the integer type.
+static bool BuiltinBswapg(Sema &S, CallExpr *TheCall) {
+ if (S.checkArgCount(TheCall, 1))
+ return true;
+ ExprResult ArgRes = S.DefaultLvalueConversion(TheCall->getArg(0));
+ if (ArgRes.isInvalid())
+ return true;
+
+ Expr *Arg = ArgRes.get();
+ TheCall->setArg(0, Arg);
+
+ QualType ArgTy = Arg->getType();
+
+ if (!ArgTy->isIntegerType()) {
+ S.Diag(Arg->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+ << 1 << /* scalar */ 1 << /* unsigned integer ty */ 1 << /* no fp */ 0
+ << ArgTy;
+ return true;
+ }
+ TheCall->setType(ArgTy);
+ return false;
+}
+
/// Checks that __builtin_popcountg was called with a single argument, which is
/// an unsigned integer.
static bool BuiltinPopcountg(Sema &S, CallExpr *TheCall) {
@@ -3448,6 +3472,10 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
}
break;
}
+ case Builtin::BI__builtin_bswapg:
+ if (BuiltinBswapg(*this, TheCall))
+ return ExprError();
+ break;
case Builtin::BI__builtin_popcountg:
if (BuiltinPopcountg(*this, TheCall))
return ExprError();
diff --git a/clang/test/AST/ByteCode/builtin-functions.cpp b/clang/test/AST/ByteCode/builtin-functions.cpp
index f47bc49d9a1a8..84ff9cc137bf3 100644
--- a/clang/test/AST/ByteCode/builtin-functions.cpp
+++ b/clang/test/AST/ByteCode/builtin-functions.cpp
@@ -824,6 +824,10 @@ namespace bswap {
int h3 = __builtin_bswap16(0x1234) == 0x3412 ? 1 : f();
int h4 = __builtin_bswap32(0x1234) == 0x34120000 ? 1 : f();
int h5 = __builtin_bswap64(0x1234) == 0x3412000000000000 ? 1 : f();
+ int h6 = __builtin_bswapg(0x12) == 0x12 ? 1 : f();
+ int h7 = __builtin_bswapg(0x1234) == 0x3412 ? 1 : f();
+ int h8 = __builtin_bswapg(0x00001234) == 0x34120000 ? 1 : f();
+ int h9 = __builtin_bswapg(0x0000000000001234) == 0x3412000000000000 ? 1 : f();
}
#define CFSTR __builtin___CFStringMakeConstantString
diff --git a/clang/test/CodeGen/builtins.c b/clang/test/CodeGen/builtins.c
index 738814c88bf56..11d8302816c84 100644
--- a/clang/test/CodeGen/builtins.c
+++ b/clang/test/CodeGen/builtins.c
@@ -130,7 +130,7 @@ int main(void) {
P(object_size, (s0, 3));
// Whatever
-
+ P(bswapg, (N));
P(bswap16, (N));
P(bswap32, (N));
P(bswap64, (N));
diff --git a/clang/test/Sema/constant-builtins-2.c b/clang/test/Sema/constant-builtins-2.c
index e465a3c5f0ad8..96bd2c966c2ef 100644
--- a/clang/test/Sema/constant-builtins-2.c
+++ b/clang/test/Sema/constant-builtins-2.c
@@ -479,6 +479,10 @@ int h0 = __builtin_types_compatible_p(int, float);
int h3 = __builtin_bswap16(0x1234) == 0x3412 ? 1 : f();
int h4 = __builtin_bswap32(0x1234) == 0x34120000 ? 1 : f();
int h5 = __builtin_bswap64(0x1234) == 0x3412000000000000 ? 1 : f();
+int h6 = __builtin_bswapg((char)(0x12)) == (char)(0x12) ? 1 : f();
+int h7 = __builtin_bswapg((short)(0x1234)) == (short)(0x3412) ? 1 : f();
+int h8 = __builtin_bswapg(0x00001234) == 0x34120000 ? 1 : f();
+int h9 = __builtin_bswapg(0x0000000000001234ULL) == 0x3412000000000000 ? 1 : f();
extern long int bi0;
extern __typeof__(__builtin_expect(0, 0)) bi0;
diff --git a/clang/test/Sema/constant-builtins.c b/clang/test/Sema/constant-builtins.c
index 964ab59e787c4..6c13fe96b6b4a 100644
--- a/clang/test/Sema/constant-builtins.c
+++ b/clang/test/Sema/constant-builtins.c
@@ -25,7 +25,10 @@ int h0 = __builtin_types_compatible_p(int,float);
int h3 = __builtin_bswap16(0x1234) == 0x3412 ? 1 : f();
int h4 = __builtin_bswap32(0x1234) == 0x34120000 ? 1 : f();
int h5 = __builtin_bswap64(0x1234) == 0x3412000000000000 ? 1 : f();
-
+int h6 = __builtin_bswapg((char)0x12) == (char)0x12 ? 1 : f();
+int h7 = __builtin_bswapg((short)(0x1234)) == (short)(0x3412) ? 1 : f();
+int h8 = __builtin_bswapg(0x00001234) == 0x34120000 ? 1 : f();
+int h9 = __builtin_bswapg(0x0000000000001234ULL) == 0x3412000000000000 ? 1 : f();
short somefunc(void);
short t = __builtin_constant_p(5353) ? 42 : somefunc();
>From d4ea8686cd97c203ec458e4cd56cd67f941bbfd0 Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Thu, 9 Oct 2025 13:14:08 +0800
Subject: [PATCH 2/7] handle special case 8 in interp__builtin_bswap and fix
extra space in VisitBuiltinCallExpr
---
clang/lib/AST/ByteCode/InterpBuiltin.cpp | 16 +++++-----------
clang/lib/AST/ExprConstant.cpp | 6 ++----
2 files changed, 7 insertions(+), 15 deletions(-)
diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
index b8d17fbce6d4e..01f2cd280b175 100644
--- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -1004,8 +1004,10 @@ static bool interp__builtin_bswap(InterpState &S, CodePtr OpPC,
const CallExpr *Call) {
const APSInt &Val = popToAPSInt(S, Call->getArg(0));
assert(Val.getActiveBits() <= 64);
-
- pushInteger(S, Val.byteSwap(), Call->getType());
+ if (Val.getBitWidth() == 8)
+ pushInteger(S, Val, Call->getType());
+ else
+ pushInteger(S, Val.byteSwap(), Call->getType());
return true;
}
@@ -3288,15 +3290,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
case Builtin::BI__builtin_elementwise_ctzg:
return interp__builtin_elementwise_countzeroes(S, OpPC, Frame, Call,
BuiltinID);
- case Builtin::BI__builtin_bswapg: {
- const APSInt &Val = popToAPSInt(S, Call->getArg(0));
- assert(Val.getActiveBits() <= 64);
- if (Val.getBitWidth() == 8)
- pushInteger(S, Val, Call->getType());
- else
- pushInteger(S, Val.byteSwap(), Call->getType());
- return true;
- }
+ case Builtin::BI__builtin_bswapg:
case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32:
case Builtin::BI__builtin_bswap64:
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 058905e7fd3c0..88c3a1cbcd833 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -13986,10 +13986,8 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
APSInt Val;
if (!EvaluateInteger(E->getArg(0), Val, Info))
return false;
- if (Val.getBitWidth() == 8) {
- bool ret = Success(Val, E);
- return ret;
- }
+ if (Val.getBitWidth() == 8)
+ return Success(Val, E);
return Success(Val.byteSwap(), E);
}
>From fa016a1bf3eb112754d24aac1823abe4e326509f Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Thu, 9 Oct 2025 22:54:57 +0800
Subject: [PATCH 3/7] add dependent check for argument
---
clang/lib/Sema/SemaChecking.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 362b53676feaa..486fc8d083125 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -2211,6 +2211,8 @@ static bool BuiltinBswapg(Sema &S, CallExpr *TheCall) {
Expr *Arg = ArgRes.get();
TheCall->setArg(0, Arg);
+ if (Arg->isTypeDependent())
+ return false;
QualType ArgTy = Arg->getType();
>From c0d0f3c179ff0dd0ccf3683cf075de492fbef12c Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Fri, 10 Oct 2025 10:56:22 +0800
Subject: [PATCH 4/7] fix bswapg codegen and add c++ tests
---
clang/lib/AST/ExprConstant.cpp | 2 +-
clang/lib/CodeGen/CGBuiltin.cpp | 10 ++-
clang/lib/Sema/SemaChecking.cpp | 2 +-
clang/test/CodeGen/builtins.c | 5 +-
clang/test/Sema/builtin-bswapg.cpp | 121 +++++++++++++++++++++++++++++
5 files changed, 136 insertions(+), 4 deletions(-)
create mode 100644 clang/test/Sema/builtin-bswapg.cpp
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 88c3a1cbcd833..745e8d9201183 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -13988,7 +13988,7 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
return false;
if (Val.getBitWidth() == 8)
return Success(Val, E);
-
+
return Success(Val.byteSwap(), E);
}
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 7733f4dc15f5d..124351e7f1e59 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -3622,7 +3622,15 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType)));
return RValue::get(ArgValue);
}
- case Builtin::BI__builtin_bswapg:
+ case Builtin::BI__builtin_bswapg: {
+ Value *ArgValue = EmitScalarExpr(E->getArg(0));
+ llvm::IntegerType *IntTy = cast<llvm::IntegerType>(ArgValue->getType());
+ assert(IntTy && "LLVM's __builtin_bswapg only supports integer variants");
+ if (IntTy->getBitWidth() == 8)
+ return RValue::get(ArgValue);
+ return RValue::get(
+ emitBuiltinWithOneOverloadedType<1>(*this, E, Intrinsic::bswap));
+ }
case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32:
case Builtin::BI__builtin_bswap64:
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 486fc8d083125..80afa08f3f3af 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -3476,7 +3476,7 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
}
case Builtin::BI__builtin_bswapg:
if (BuiltinBswapg(*this, TheCall))
- return ExprError();
+ return ExprError();
break;
case Builtin::BI__builtin_popcountg:
if (BuiltinPopcountg(*this, TheCall))
diff --git a/clang/test/CodeGen/builtins.c b/clang/test/CodeGen/builtins.c
index 11d8302816c84..66ac8ad7431fb 100644
--- a/clang/test/CodeGen/builtins.c
+++ b/clang/test/CodeGen/builtins.c
@@ -130,7 +130,10 @@ int main(void) {
P(object_size, (s0, 3));
// Whatever
- P(bswapg, (N));
+ P(bswapg, ((char)N));
+ P(bswapg, ((short)N));
+ P(bswapg, ((int)N));
+ P(bswapg, ((unsigned long)N));
P(bswap16, (N));
P(bswap32, (N));
P(bswap64, (N));
diff --git a/clang/test/Sema/builtin-bswapg.cpp b/clang/test/Sema/builtin-bswapg.cpp
new file mode 100644
index 0000000000000..c7fa6f2410023
--- /dev/null
+++ b/clang/test/Sema/builtin-bswapg.cpp
@@ -0,0 +1,121 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUN: %clang_cc1 -fsyntax-only -verify -fexperimental-new-constant-interpreter %s
+// expected-no-diagnostics
+template <class A, class B>
+static constexpr bool is_same_type = false;
+
+template <class A>
+static constexpr bool is_same_type<A, A> = true;
+
+void test_basic_type_checks() {
+ static_assert(is_same_type<char, decltype(__builtin_bswapg((char)0))>, "");
+ static_assert(is_same_type<unsigned char, decltype(__builtin_bswapg((unsigned char)0))>, "");
+ static_assert(is_same_type<short, decltype(__builtin_bswapg((short)0))>, "");
+ static_assert(is_same_type<unsigned short, decltype(__builtin_bswapg((unsigned short)0))>, "");
+ static_assert(is_same_type<int, decltype(__builtin_bswapg((int)0))>, "");
+ static_assert(is_same_type<unsigned int, decltype(__builtin_bswapg((unsigned int)0))>, "");
+ static_assert(is_same_type<long, decltype(__builtin_bswapg((long)0))>, "");
+ static_assert(is_same_type<unsigned long, decltype(__builtin_bswapg((unsigned long)0))>, "");
+}
+
+template<typename T>
+void test_template_type_check() {
+ static_assert(is_same_type<T, decltype(__builtin_bswapg(T{}))>,
+ "bswapg should return the same type as its argument");
+ constexpr T zero{};
+ constexpr T max = ~T{};
+ constexpr T one = T{1};
+
+ static_assert(is_same_type<T, decltype(__builtin_bswapg(zero))>, "");
+ static_assert(is_same_type<T, decltype(__builtin_bswapg(max))>, "");
+ static_assert(is_same_type<T, decltype(__builtin_bswapg(one))>, "");
+}
+template void test_template_type_check<char>();
+template void test_template_type_check<unsigned char>();
+template void test_template_type_check<short>();
+template void test_template_type_check<unsigned short>();
+template void test_template_type_check<int>();
+template void test_template_type_check<unsigned int>();
+template void test_template_type_check<long>();
+template void test_template_type_check<unsigned long>();
+
+void test_lambda_type_checks() {
+ auto lambda = [](auto x) {
+ static_assert(is_same_type<decltype(x), decltype(__builtin_bswapg(x))>,
+ "bswapg in lambda should preserve type");
+ return __builtin_bswapg(x);
+ };
+ auto result_long = lambda(42UL);
+ static_assert(is_same_type<unsigned long, decltype(result_long)>, "");
+
+ auto result_int = lambda(42);
+ static_assert(is_same_type<int, decltype(result_int)>, "");
+
+ auto result_short = lambda(static_cast<short>(42));
+ static_assert(is_same_type<short, decltype(result_short)>, "");
+
+ auto result_char = lambda(static_cast<char>(42));
+ static_assert(is_same_type<char, decltype(result_char)>, "");
+}
+
+auto test_auto_return_type_long(long x) {
+ auto result = __builtin_bswapg(x);
+ static_assert(is_same_type<long, decltype(result)>, "");
+ return result;
+}
+
+auto test_auto_return_type_int(int x) {
+ auto result = __builtin_bswapg(x);
+ static_assert(is_same_type<int, decltype(result)>, "");
+ return result;
+}
+
+auto test_auto_return_type_short(short x) {
+ auto result = __builtin_bswapg(x);
+ static_assert(is_same_type<short, decltype(result)>, "");
+ return result;
+}
+
+auto test_auto_return_type_char(char x) {
+ auto result = __builtin_bswapg(x);
+ static_assert(is_same_type<char, decltype(result)>, "");
+ return result;
+}
+
+void test_auto_return_type() {
+ test_auto_return_type_long(42);
+ test_auto_return_type_int(42);
+ test_auto_return_type_short(42);
+ test_auto_return_type_char(42);
+}
+
+decltype(auto) test_decltype_auto(int x) {
+ return __builtin_bswapg(x);
+}
+
+void test_decltype_auto_check() {
+ int x = 42;
+ auto result = test_decltype_auto(x);
+ static_assert(is_same_type<int, decltype(result)>, "");
+}
+
+template<auto Value>
+struct ValueTemplateTypeTest {
+ using value_type = decltype(Value);
+ using result_type = decltype(__builtin_bswapg(Value));
+
+ static constexpr bool type_matches = is_same_type<value_type, result_type>;
+ static_assert(type_matches, "Value template bswapg should preserve type");
+
+ static constexpr auto swapped_value = __builtin_bswapg(Value);
+};
+
+template<auto... Values>
+void test_template_pack_types() {
+ static_assert((is_same_type<decltype(Values), decltype(__builtin_bswapg(Values))> && ...), "All pack elements should preserve type");
+}
+
+template struct ValueTemplateTypeTest<0x1234>;
+template struct ValueTemplateTypeTest<0x12345678UL>;
+template struct ValueTemplateTypeTest<(short)0x1234>;
+template struct ValueTemplateTypeTest<(char)0x12>;
\ No newline at end of file
>From 1e9895c3aa7d648c5a7bdb78f6d3e3dd8bee4430 Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Fri, 10 Oct 2025 16:14:21 +0800
Subject: [PATCH 5/7] fix test for builtin-bswapg
---
clang/test/CodeGen/builtins.c | 4 +-
clang/test/Sema/builtin-bswapg.cpp | 121 --------------------------
clang/test/SemaCXX/builtin-bswapg.cpp | 85 ++++++++++++++++++
3 files changed, 87 insertions(+), 123 deletions(-)
delete mode 100644 clang/test/Sema/builtin-bswapg.cpp
create mode 100644 clang/test/SemaCXX/builtin-bswapg.cpp
diff --git a/clang/test/CodeGen/builtins.c b/clang/test/CodeGen/builtins.c
index 66ac8ad7431fb..f9bbc26e1473f 100644
--- a/clang/test/CodeGen/builtins.c
+++ b/clang/test/CodeGen/builtins.c
@@ -132,8 +132,8 @@ int main(void) {
// Whatever
P(bswapg, ((char)N));
P(bswapg, ((short)N));
- P(bswapg, ((int)N));
- P(bswapg, ((unsigned long)N));
+ P(bswapg, ((int)N));
+ P(bswapg, ((unsigned long)N));
P(bswap16, (N));
P(bswap32, (N));
P(bswap64, (N));
diff --git a/clang/test/Sema/builtin-bswapg.cpp b/clang/test/Sema/builtin-bswapg.cpp
deleted file mode 100644
index c7fa6f2410023..0000000000000
--- a/clang/test/Sema/builtin-bswapg.cpp
+++ /dev/null
@@ -1,121 +0,0 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s
-// RUN: %clang_cc1 -fsyntax-only -verify -fexperimental-new-constant-interpreter %s
-// expected-no-diagnostics
-template <class A, class B>
-static constexpr bool is_same_type = false;
-
-template <class A>
-static constexpr bool is_same_type<A, A> = true;
-
-void test_basic_type_checks() {
- static_assert(is_same_type<char, decltype(__builtin_bswapg((char)0))>, "");
- static_assert(is_same_type<unsigned char, decltype(__builtin_bswapg((unsigned char)0))>, "");
- static_assert(is_same_type<short, decltype(__builtin_bswapg((short)0))>, "");
- static_assert(is_same_type<unsigned short, decltype(__builtin_bswapg((unsigned short)0))>, "");
- static_assert(is_same_type<int, decltype(__builtin_bswapg((int)0))>, "");
- static_assert(is_same_type<unsigned int, decltype(__builtin_bswapg((unsigned int)0))>, "");
- static_assert(is_same_type<long, decltype(__builtin_bswapg((long)0))>, "");
- static_assert(is_same_type<unsigned long, decltype(__builtin_bswapg((unsigned long)0))>, "");
-}
-
-template<typename T>
-void test_template_type_check() {
- static_assert(is_same_type<T, decltype(__builtin_bswapg(T{}))>,
- "bswapg should return the same type as its argument");
- constexpr T zero{};
- constexpr T max = ~T{};
- constexpr T one = T{1};
-
- static_assert(is_same_type<T, decltype(__builtin_bswapg(zero))>, "");
- static_assert(is_same_type<T, decltype(__builtin_bswapg(max))>, "");
- static_assert(is_same_type<T, decltype(__builtin_bswapg(one))>, "");
-}
-template void test_template_type_check<char>();
-template void test_template_type_check<unsigned char>();
-template void test_template_type_check<short>();
-template void test_template_type_check<unsigned short>();
-template void test_template_type_check<int>();
-template void test_template_type_check<unsigned int>();
-template void test_template_type_check<long>();
-template void test_template_type_check<unsigned long>();
-
-void test_lambda_type_checks() {
- auto lambda = [](auto x) {
- static_assert(is_same_type<decltype(x), decltype(__builtin_bswapg(x))>,
- "bswapg in lambda should preserve type");
- return __builtin_bswapg(x);
- };
- auto result_long = lambda(42UL);
- static_assert(is_same_type<unsigned long, decltype(result_long)>, "");
-
- auto result_int = lambda(42);
- static_assert(is_same_type<int, decltype(result_int)>, "");
-
- auto result_short = lambda(static_cast<short>(42));
- static_assert(is_same_type<short, decltype(result_short)>, "");
-
- auto result_char = lambda(static_cast<char>(42));
- static_assert(is_same_type<char, decltype(result_char)>, "");
-}
-
-auto test_auto_return_type_long(long x) {
- auto result = __builtin_bswapg(x);
- static_assert(is_same_type<long, decltype(result)>, "");
- return result;
-}
-
-auto test_auto_return_type_int(int x) {
- auto result = __builtin_bswapg(x);
- static_assert(is_same_type<int, decltype(result)>, "");
- return result;
-}
-
-auto test_auto_return_type_short(short x) {
- auto result = __builtin_bswapg(x);
- static_assert(is_same_type<short, decltype(result)>, "");
- return result;
-}
-
-auto test_auto_return_type_char(char x) {
- auto result = __builtin_bswapg(x);
- static_assert(is_same_type<char, decltype(result)>, "");
- return result;
-}
-
-void test_auto_return_type() {
- test_auto_return_type_long(42);
- test_auto_return_type_int(42);
- test_auto_return_type_short(42);
- test_auto_return_type_char(42);
-}
-
-decltype(auto) test_decltype_auto(int x) {
- return __builtin_bswapg(x);
-}
-
-void test_decltype_auto_check() {
- int x = 42;
- auto result = test_decltype_auto(x);
- static_assert(is_same_type<int, decltype(result)>, "");
-}
-
-template<auto Value>
-struct ValueTemplateTypeTest {
- using value_type = decltype(Value);
- using result_type = decltype(__builtin_bswapg(Value));
-
- static constexpr bool type_matches = is_same_type<value_type, result_type>;
- static_assert(type_matches, "Value template bswapg should preserve type");
-
- static constexpr auto swapped_value = __builtin_bswapg(Value);
-};
-
-template<auto... Values>
-void test_template_pack_types() {
- static_assert((is_same_type<decltype(Values), decltype(__builtin_bswapg(Values))> && ...), "All pack elements should preserve type");
-}
-
-template struct ValueTemplateTypeTest<0x1234>;
-template struct ValueTemplateTypeTest<0x12345678UL>;
-template struct ValueTemplateTypeTest<(short)0x1234>;
-template struct ValueTemplateTypeTest<(char)0x12>;
\ No newline at end of file
diff --git a/clang/test/SemaCXX/builtin-bswapg.cpp b/clang/test/SemaCXX/builtin-bswapg.cpp
new file mode 100644
index 0000000000000..229c7fcac1522
--- /dev/null
+++ b/clang/test/SemaCXX/builtin-bswapg.cpp
@@ -0,0 +1,85 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUN: %clang_cc1 -fsyntax-only -verify -fexperimental-new-constant-interpreter %s
+// expected-no-diagnostics
+
+void test_basic_type_checks() {
+ static_assert(__is_same(char, decltype(__builtin_bswapg((char)0))), "");
+ static_assert(__is_same(unsigned char, decltype(__builtin_bswapg((unsigned char)0))), "");
+ static_assert(__is_same(short, decltype(__builtin_bswapg((short)0))), "");
+ static_assert(__is_same(unsigned short, decltype(__builtin_bswapg((unsigned short)0))), "");
+ static_assert(__is_same(int, decltype(__builtin_bswapg((int)0))), "");
+ static_assert(__is_same(unsigned int, decltype(__builtin_bswapg((unsigned int)0))), "");
+ static_assert(__is_same(long, decltype(__builtin_bswapg((long)0))), "");
+ static_assert(__is_same(unsigned long, decltype(__builtin_bswapg((unsigned long)0))), "");
+}
+
+template<typename T>
+void test_template_type_check() {
+ static_assert(__is_same(T, decltype(__builtin_bswapg(T{}))),
+ "bswapg should return the same type as its argument");
+ constexpr T zero{};
+ constexpr T max = ~T{};
+ constexpr T one = T{1};
+
+ static_assert(__is_same(T, decltype(__builtin_bswapg(zero))), "");
+ static_assert(__is_same(T, decltype(__builtin_bswapg(max))), "");
+ static_assert(__is_same(T, decltype(__builtin_bswapg(one))), "");
+}
+template void test_template_type_check<char>();
+template void test_template_type_check<unsigned char>();
+template void test_template_type_check<short>();
+template void test_template_type_check<unsigned short>();
+template void test_template_type_check<int>();
+template void test_template_type_check<unsigned int>();
+template void test_template_type_check<long>();
+template void test_template_type_check<unsigned long>();
+
+void test_lambda_type_checks() {
+ auto lambda = [](auto x) {
+ static_assert(__is_same(decltype(x), decltype(__builtin_bswapg(x))),
+ "bswapg in lambda should preserve type");
+ return __builtin_bswapg(x);
+ };
+ auto result_long = lambda(42UL);
+ static_assert(__is_same(unsigned long, decltype(result_long)), "");
+
+ auto result_int = lambda(42);
+ static_assert(__is_same(int, decltype(result_int)), "");
+
+ auto result_short = lambda(static_cast<short>(42));
+ static_assert(__is_same(short, decltype(result_short)), "");
+
+ auto result_char = lambda(static_cast<char>(42));
+ static_assert(__is_same(char, decltype(result_char)), "");
+}
+
+decltype(auto) test_decltype_auto(int x) {
+ return __builtin_bswapg(x);
+}
+
+void test_decltype_auto_check() {
+ int x = 42;
+ auto result = test_decltype_auto(x);
+ static_assert(__is_same(int, decltype(result)), "");
+}
+
+template<auto Value>
+struct ValueTemplateTypeTest {
+ using value_type = decltype(Value);
+ using result_type = decltype(__builtin_bswapg(Value));
+
+ static constexpr bool type_matches = __is_same(value_type, result_type);
+ static_assert(type_matches, "Value template bswapg should preserve type");
+
+ static constexpr auto swapped_value = __builtin_bswapg(Value);
+};
+
+template<auto... Values>
+void test_template_pack_types() {
+ static_assert((__is_same(decltype(Values), decltype(__builtin_bswapg(Values))) && ...), "All pack elements should preserve type");
+}
+
+template struct ValueTemplateTypeTest<0x1234>;
+template struct ValueTemplateTypeTest<0x12345678UL>;
+template struct ValueTemplateTypeTest<(short)0x1234>;
+template struct ValueTemplateTypeTest<(char)0x12>;
>From bca24f27114267572db5640ef7fced407ebde443 Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Sun, 12 Oct 2025 18:04:41 +0800
Subject: [PATCH 6/7] add failure tests and reference tests, and adjust checks
according to conversation
---
clang/lib/AST/ExprConstant.cpp | 13 +---
clang/lib/CodeGen/CGBuiltin.cpp | 2 +
clang/lib/Sema/SemaChecking.cpp | 2 +-
clang/test/AST/ByteCode/builtin-functions.cpp | 19 +++++
clang/test/CodeGenCXX/builtins.cpp | 37 +++++++++
clang/test/Sema/constant-builtins-2.c | 4 +
clang/test/SemaCXX/builtin-bswapg.cpp | 77 ++++++++++++++++++-
7 files changed, 142 insertions(+), 12 deletions(-)
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 745e8d9201183..f4490fcc8ac66 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -13982,22 +13982,15 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
return Success(Val.reverseBits(), E);
}
- case Builtin::BI__builtin_bswapg: {
- APSInt Val;
- if (!EvaluateInteger(E->getArg(0), Val, Info))
- return false;
- if (Val.getBitWidth() == 8)
- return Success(Val, E);
-
- return Success(Val.byteSwap(), E);
- }
-
+ case Builtin::BI__builtin_bswapg:
case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32:
case Builtin::BI__builtin_bswap64: {
APSInt Val;
if (!EvaluateInteger(E->getArg(0), Val, Info))
return false;
+ if (Val.getBitWidth() == 8)
+ return Success(Val, E);
return Success(Val.byteSwap(), E);
}
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 124351e7f1e59..cc76024f335db 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -3626,6 +3626,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
Value *ArgValue = EmitScalarExpr(E->getArg(0));
llvm::IntegerType *IntTy = cast<llvm::IntegerType>(ArgValue->getType());
assert(IntTy && "LLVM's __builtin_bswapg only supports integer variants");
+ assert(((IntTy->getBitWidth() % 16 == 0 && IntTy->getBitWidth() != 0) || IntTy->getBitWidth() == 8) &&
+ "LLVM's __builtin_bswapg only supports integer variants that has a multiple of 16 bits as well as a single byte");
if (IntTy->getBitWidth() == 8)
return RValue::get(ArgValue);
return RValue::get(
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 80afa08f3f3af..6c9ec326f1fde 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -2218,7 +2218,7 @@ static bool BuiltinBswapg(Sema &S, CallExpr *TheCall) {
if (!ArgTy->isIntegerType()) {
S.Diag(Arg->getBeginLoc(), diag::err_builtin_invalid_arg_type)
- << 1 << /* scalar */ 1 << /* unsigned integer ty */ 1 << /* no fp */ 0
+ << 1 << /*scalar=*/ 1 << /*unsigned integer=*/ 1 << /*floating point=*/ 0
<< ArgTy;
return true;
}
diff --git a/clang/test/AST/ByteCode/builtin-functions.cpp b/clang/test/AST/ByteCode/builtin-functions.cpp
index 84ff9cc137bf3..9248f835832f3 100644
--- a/clang/test/AST/ByteCode/builtin-functions.cpp
+++ b/clang/test/AST/ByteCode/builtin-functions.cpp
@@ -828,6 +828,25 @@ namespace bswap {
int h7 = __builtin_bswapg(0x1234) == 0x3412 ? 1 : f();
int h8 = __builtin_bswapg(0x00001234) == 0x34120000 ? 1 : f();
int h9 = __builtin_bswapg(0x0000000000001234) == 0x3412000000000000 ? 1 : f();
+
+ constexpr const int const_expr = 0x1234;
+
+ void test_constexpr_reference() {
+ const int expr = 0x1234;
+ const int& ref = expr; // #declare
+
+ constexpr const int& const_ref = const_expr;
+
+ constexpr auto result2 = __builtin_bswapg(ref);
+ //expected-error at -1 {{constexpr variable 'result2' must be initialized by a constant expression}}
+ //expected-note at -2 {{initializer of 'ref' is not a constant expression}}
+ //expected-note@#declare {{declared here}}
+ //ref-error at -4 {{constexpr variable 'result2' must be initialized by a constant expression}}
+ //ref-note at -5 {{initializer of 'ref' is not a constant expression}}
+ //ref-note@#declare {{declared here}}
+
+ constexpr auto result3 = __builtin_bswapg(const_ref);
+ }
}
#define CFSTR __builtin___CFStringMakeConstantString
diff --git a/clang/test/CodeGenCXX/builtins.cpp b/clang/test/CodeGenCXX/builtins.cpp
index 9169f3a3276d3..165f5cdb7cd48 100644
--- a/clang/test/CodeGenCXX/builtins.cpp
+++ b/clang/test/CodeGenCXX/builtins.cpp
@@ -83,3 +83,40 @@ int structured_binding_size() {
return __builtin_structured_binding_size(S2);
// CHECK: ret i32 2
}
+
+void test_int_reference(int& a) {
+ __builtin_bswapg(a);
+}
+// CHECK-LABEL: @_Z18test_int_referenceRi
+// CHECK: store ptr %a, ptr
+// CHECK: load ptr, ptr
+// CHECK: load i32, ptr
+// CHECK: call i32 @llvm.bswap.i32
+
+void test_long_reference(long& a) {
+ __builtin_bswapg(a);
+}
+// CHECK-LABEL: @_Z19test_long_referenceRl
+// CHECK: store ptr %a, ptr
+// CHECK: load ptr, ptr
+// CHECK: load i64, ptr
+// CHECK: call i64 @llvm.bswap.i64
+
+// 2. 不同大小的引用测试
+void test_short_reference(short& a) {
+ __builtin_bswapg(a);
+}
+// CHECK-LABEL: @_Z20test_short_referenceRs
+// CHECK: store ptr %a, ptr
+// CHECK: load ptr, ptr
+// CHECK: load i16, ptr
+// CHECK: call i16 @llvm.bswap.i16
+
+void test_char_reference(char& a) {
+ __builtin_bswapg(a);
+}
+// CHECK-LABEL: @_Z19test_char_referenceRc
+// CHECK: store ptr %a, ptr
+// CHECK: load ptr, ptr
+// CHECK-NOT: call i8 @llvm.bswap.i8
+// CHECK: ret void
diff --git a/clang/test/Sema/constant-builtins-2.c b/clang/test/Sema/constant-builtins-2.c
index 96bd2c966c2ef..ff15715a0c41c 100644
--- a/clang/test/Sema/constant-builtins-2.c
+++ b/clang/test/Sema/constant-builtins-2.c
@@ -483,6 +483,10 @@ int h6 = __builtin_bswapg((char)(0x12)) == (char)(0x12) ? 1 : f();
int h7 = __builtin_bswapg((short)(0x1234)) == (short)(0x3412) ? 1 : f();
int h8 = __builtin_bswapg(0x00001234) == 0x34120000 ? 1 : f();
int h9 = __builtin_bswapg(0x0000000000001234ULL) == 0x3412000000000000 ? 1 : f();
+float h10 = __builtin_bswapg(1.0f); // expected-error {{1st argument must be a scalar integer type (was 'float')}}
+double h12 = __builtin_bswapg(1.0L); // expected-error {{1st argument must be a scalar integer type (was 'long double')}}
+char *h13 = __builtin_bswapg("hello"); // expected-error {{1st argument must be a scalar integer type (was 'char[6]')}}
+int h14 = __builtin_bswapg(1, 2); // expected-error {{too many arguments to function call, expected 1, have 2}}
extern long int bi0;
extern __typeof__(__builtin_expect(0, 0)) bi0;
diff --git a/clang/test/SemaCXX/builtin-bswapg.cpp b/clang/test/SemaCXX/builtin-bswapg.cpp
index 229c7fcac1522..1e7f2790e60cc 100644
--- a/clang/test/SemaCXX/builtin-bswapg.cpp
+++ b/clang/test/SemaCXX/builtin-bswapg.cpp
@@ -1,6 +1,5 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
// RUN: %clang_cc1 -fsyntax-only -verify -fexperimental-new-constant-interpreter %s
-// expected-no-diagnostics
void test_basic_type_checks() {
static_assert(__is_same(char, decltype(__builtin_bswapg((char)0))), "");
@@ -83,3 +82,79 @@ template struct ValueTemplateTypeTest<0x1234>;
template struct ValueTemplateTypeTest<0x12345678UL>;
template struct ValueTemplateTypeTest<(short)0x1234>;
template struct ValueTemplateTypeTest<(char)0x12>;
+
+template<typename T>
+void test_invalid_type() {
+ __builtin_bswapg(T{}); // #invalid_type_use
+}
+
+void test_basic_errors() {
+ test_invalid_type<float>();
+ // expected-note at -1 {{in instantiation of function template specialization 'test_invalid_type<float>' requested here}}
+ // expected-error@#invalid_type_use {{1st argument must be a scalar integer type (was 'float')}}
+
+ test_invalid_type<double>();
+ // expected-note at -1 {{in instantiation of function template specialization 'test_invalid_type<double>' requested here}}
+ // expected-error@#invalid_type_use {{1st argument must be a scalar integer type (was 'double')}}
+
+ test_invalid_type<void*>();
+ // expected-note at -1 {{in instantiation of function template specialization 'test_invalid_type<void *>' requested here}}
+ // expected-error@#invalid_type_use {{1st argument must be a scalar integer type (was 'void *')}}
+}
+
+template<typename T>
+auto test_dependent_context(T value) -> decltype(__builtin_bswapg(value)) { // #dependent_use
+ return __builtin_bswapg(value);
+}
+
+void test_dependent_errors() {
+ test_dependent_context(1.0f);
+ // expected-error at -1 {{no matching function for call to 'test_dependent_context'}}
+ // expected-note@#dependent_use {{candidate template ignored: substitution failure [with T = float]: 1st argument must be a scalar integer type (was 'float')}}
+ test_dependent_context(1.0l);
+ // expected-error at -1 {{no matching function for call to 'test_dependent_context'}}
+ // expected-note@#dependent_use {{candidate template ignored: substitution failure [with T = long double]: 1st argument must be a scalar integer type (was 'long double')}}
+ test_dependent_context("hello");
+ // expected-error at -1 {{no matching function for call to 'test_dependent_context'}}
+ // expected-note@#dependent_use {{candidate template ignored: substitution failure [with T = const char *]: 1st argument must be a scalar integer type (was 'const char *')}}
+}
+
+void test_lambda_errors() {
+ auto lambda = [](auto x) {
+ return __builtin_bswapg(x); // #lambda_use
+ };
+
+ lambda(1.0f);
+ // expected-error@#lambda_use {{1st argument must be a scalar integer type (was 'float')}}
+ // expected-note at -2 {{in instantiation of function template specialization 'test_lambda_errors()::(anonymous class)::operator()<float>' requested here}}
+ lambda(1.0l);
+ // expected-error@#lambda_use {{1st argument must be a scalar integer type (was 'long double')}}
+ // expected-note at -2 {{in instantiation of function template specialization 'test_lambda_errors()::(anonymous class)::operator()<long double>' requested here}}
+ lambda("hello");
+ // expected-error@#lambda_use {{1st argument must be a scalar integer type (was 'const char *')}}
+ // expected-note at -2 {{in instantiation of function template specialization 'test_lambda_errors()::(anonymous class)::operator()<const char *>' requested here}}
+}
+
+void test_argument_count_errors() {
+ int h14 = __builtin_bswapg(1, 2); // expected-error {{too many arguments to function call, expected 1, have 2}}
+}
+
+void test_lvalue_reference(int& a) {
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay reference to value type");
+}
+
+void test_const_lvalue_reference(const int& a) {
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay const reference to value type");
+}
+
+void test_rvalue_reference(int&& a) {
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay rvalue reference to value type");
+}
+
+void test_const_rvalue_reference(const int&& a) {
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay const rvalue reference to value type");
+}
>From ba83b56d21c3f74c0fa6a764b70915f8c0d7904c Mon Sep 17 00:00:00 2001
From: clingfei <1599101385 at qq.com>
Date: Wed, 15 Oct 2025 14:54:50 +0800
Subject: [PATCH 7/7] add tests for arrays, pointers, enums, class, nullptr_t
---
clang/test/Sema/constant-builtins-2.c | 7 ++++
clang/test/SemaCXX/builtin-bswapg.cpp | 58 +++++++++++++++++++++++----
2 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/clang/test/Sema/constant-builtins-2.c b/clang/test/Sema/constant-builtins-2.c
index ff15715a0c41c..a7d92fe96bc06 100644
--- a/clang/test/Sema/constant-builtins-2.c
+++ b/clang/test/Sema/constant-builtins-2.c
@@ -487,6 +487,13 @@ float h10 = __builtin_bswapg(1.0f); // expected-error {{1st argument must be a s
double h12 = __builtin_bswapg(1.0L); // expected-error {{1st argument must be a scalar integer type (was 'long double')}}
char *h13 = __builtin_bswapg("hello"); // expected-error {{1st argument must be a scalar integer type (was 'char[6]')}}
int h14 = __builtin_bswapg(1, 2); // expected-error {{too many arguments to function call, expected 1, have 2}}
+int *h15 = __builtin_bswapg(&h9); // expected-error {{1st argument must be a scalar integer type (was 'int *')}}
+int arr[4] = {0x12, 0x34, 0x56, 0x78};
+int h16 = __builtin_bswapg(arr); // expected-error {{1st argument must be a scalar integer type (was 'int[4]')}}
+enum BasicEnum {
+ ENUM_VALUE1 = 0x1234,
+};
+int h17 = __builtin_bswapg(ENUM_VALUE1) == 0x34120000 ? 1 : f();
extern long int bi0;
extern __typeof__(__builtin_expect(0, 0)) bi0;
diff --git a/clang/test/SemaCXX/builtin-bswapg.cpp b/clang/test/SemaCXX/builtin-bswapg.cpp
index 1e7f2790e60cc..26bc5b54fae78 100644
--- a/clang/test/SemaCXX/builtin-bswapg.cpp
+++ b/clang/test/SemaCXX/builtin-bswapg.cpp
@@ -140,21 +140,63 @@ void test_argument_count_errors() {
}
void test_lvalue_reference(int& a) {
- auto result = __builtin_bswapg(a);
- static_assert(__is_same(int, decltype(result)), "Should decay reference to value type");
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay reference to value type");
}
void test_const_lvalue_reference(const int& a) {
- auto result = __builtin_bswapg(a);
- static_assert(__is_same(int, decltype(result)), "Should decay const reference to value type");
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay const reference to value type");
}
void test_rvalue_reference(int&& a) {
- auto result = __builtin_bswapg(a);
- static_assert(__is_same(int, decltype(result)), "Should decay rvalue reference to value type");
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay rvalue reference to value type");
}
void test_const_rvalue_reference(const int&& a) {
- auto result = __builtin_bswapg(a);
- static_assert(__is_same(int, decltype(result)), "Should decay const rvalue reference to value type");
+ auto result = __builtin_bswapg(a);
+ static_assert(__is_same(int, decltype(result)), "Should decay const rvalue reference to value type");
+}
+
+void test_array() {
+ int arr[4] = {0x12, 0x34, 0x56, 0x78};
+ __builtin_bswapg(arr);
+ // expected-error at -1 {{1st argument must be a scalar integer type (was 'int[4]')}}
+}
+
+void test_pointer() {
+ int x = 0x12345678;
+ int *ptr = &x;
+ __builtin_bswapg(ptr);
+ // expected-error at -1 {{1st argument must be a scalar integer type (was 'int *')}}
+}
+
+enum BasicEnum {
+ ENUM_VALUE1 = 0x1234,
+ ENUM_VALUE2 = 0x34120000
+};
+
+void test_enum() {
+ const BasicEnum e = ENUM_VALUE1;
+ static_assert(__builtin_bswapg(e) == ENUM_VALUE2, "");
+}
+
+class testClass {
+public:
+ int value;
+ testClass(int v) : value(v) {}
+
+ int getValue() { return value; }
+};
+
+void test_class() {
+ testClass c((int)0x12345678);
+ __builtin_bswapg(c);
+ // expected-error at -1 {{1st argument must be a scalar integer type (was 'testClass')}}
+}
+
+void test_nullptr() {
+ __builtin_bswapg(nullptr);
+ // expected-error at -1 {{1st argument must be a scalar integer type (was 'std::nullptr_t')}}
}
More information about the cfe-commits
mailing list