[clang] a289e2f - [OpenACC] Ensure ArrayRef and SmallVector are kept in sync. (#163273)

[via cfe-commits]

Author: Erich Keane
Date: 2025-10-13T14:55:13-07:00
New Revision: a289e2f9e69cdc6eef852adc45d7ce8458f38377

URL: https://github.com/llvm/llvm-project/commit/a289e2f9e69cdc6eef852adc45d7ce8458f38377
DIFF: https://github.com/llvm/llvm-project/commit/a289e2f9e69cdc6eef852adc45d7ce8458f38377.diff

LOG: [OpenACC] Ensure ArrayRef and SmallVector are kept in sync. (#163273)

My OpenACCReductionRecipeWithStorage attempted to get its allocations in
sync with the ArrayRef so I could use the arrayref to refer to the
allocation. Unfortunately I'd forgotten about the move constructor,
  which made it get out of sync, which Asan caught.

Added: 
    

Modified: 
    clang/include/clang/AST/OpenACCClause.h

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/AST/OpenACCClause.h b/clang/include/clang/AST/OpenACCClause.h
index 379495c658825..1e351f31f4b92 100644
--- a/clang/include/clang/AST/OpenACCClause.h
+++ b/clang/include/clang/AST/OpenACCClause.h
@@ -1311,13 +1311,37 @@ struct OpenACCReductionRecipe {
 // the OpenACCReductionClause node has been created.  This one has storage for
 // the CombinerRecipe, since Trailing storage for it doesn't exist yet.
 struct OpenACCReductionRecipeWithStorage : OpenACCReductionRecipe {
+private:
   llvm::SmallVector<CombinerRecipe, 1> CombinerRecipeStorage;
 
+public:
   OpenACCReductionRecipeWithStorage(VarDecl *A,
                                     llvm::ArrayRef<CombinerRecipe> Combiners)
       : OpenACCReductionRecipe(A, {}), CombinerRecipeStorage(Combiners) {
     CombinerRecipes = CombinerRecipeStorage;
   }
+
+  OpenACCReductionRecipeWithStorage(
+      const OpenACCReductionRecipeWithStorage &Other)
+      : OpenACCReductionRecipe(Other),
+        CombinerRecipeStorage(Other.CombinerRecipeStorage) {
+    CombinerRecipes = CombinerRecipeStorage;
+  }
+
+  OpenACCReductionRecipeWithStorage(OpenACCReductionRecipeWithStorage &&Other)
+      : OpenACCReductionRecipe(std::move(Other)),
+        CombinerRecipeStorage(std::move(Other.CombinerRecipeStorage)) {
+    CombinerRecipes = CombinerRecipeStorage;
+  }
+
+  // There is no real problem implementing these, we just have to make sure the
+  // array-ref this inherits from stays in sync. But as we don't need it at the
+  // moment, make sure we don't accidentially call these.
+  OpenACCReductionRecipeWithStorage &
+  operator=(OpenACCReductionRecipeWithStorage &&) = delete;
+  OpenACCReductionRecipeWithStorage &
+  operator=(const OpenACCReductionRecipeWithStorage &) = delete;
+
   static OpenACCReductionRecipeWithStorage Empty() {
     return OpenACCReductionRecipeWithStorage(/*AllocaDecl=*/nullptr, {});
   }