[clang] [clang][perf-training] Fix training when path to cmake has spaces in it (PR #162919)

Tom Stellard via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 10 13:56:07 PDT 2025


https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/162919

I uncovered this problem while trying to build release binaries on Windows with PGO.

>From 9f5e287c35ce31a9ed34f5f3eaf86da5eb936c92 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Fri, 10 Oct 2025 13:54:28 -0700
Subject: [PATCH] [clang][perf-training] Fix training when path to cmake has
 spaces in it

I uncovered this problem while trying to build release binaries on
Windows with PGO.
---
 clang/utils/perf-training/lit.site.cfg.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/clang/utils/perf-training/lit.site.cfg.in b/clang/utils/perf-training/lit.site.cfg.in
index da81ec21a28a6..7a2f162539909 100644
--- a/clang/utils/perf-training/lit.site.cfg.in
+++ b/clang/utils/perf-training/lit.site.cfg.in
@@ -1,6 +1,7 @@
 @LIT_SITE_CFG_IN_HEADER@
 
 import sys
+import shlex
 
 config.clang_tools_dir = lit_config.substitute("@CURRENT_TOOLS_DIR@")
 config.perf_helper_dir = "@CMAKE_CURRENT_SOURCE_DIR@"
@@ -8,7 +9,7 @@ config.test_exec_root = "@CMAKE_CURRENT_BINARY_DIR@"
 config.test_source_root = "@CLANG_PGO_TRAINING_DATA@"
 config.target_triple = "@LLVM_TARGET_TRIPLE@"
 config.python_exe = "@Python3_EXECUTABLE@"
-config.cmake_exe = "@CMAKE_COMMAND@"
+config.cmake_exe =  shlex.quote("@CMAKE_COMMAND@")
 config.llvm_src_dir ="@CMAKE_SOURCE_DIR@"
 config.cmake_generator ="@CMAKE_GENERATOR@"
 config.use_llvm_build = @CLANG_PGO_TRAINING_USE_LLVM_BUILD@



More information about the cfe-commits mailing list