[clang] [analyzer] Avoid use of `CallEvent`s with obsolete state (PR #160707)

[Artem Dergachev via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/160707 at github.com>


haoNoQ wrote:

Ohh. Right right right. Misread. My bad.

You probably shouldn't write a lot of code that you're about to delete anyway. So in my opinion it doesn't make sense to make a unit test or a debug checker just for this patch.

Maybe just assert that the states are the same before you pass it to the checker in evalCall? It's very slightly unobvious there with the whole loop thing and that's where the problem was anyway. Or just leave it as-is.

If you won't be able to do the follow-up commit then you can add a clever follow-up test instead.

https://github.com/llvm/llvm-project/pull/160707