[clang] [tests] Split up darwin-macatalyst test (PR #162358)

Cyndy Ishida via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 7 12:53:08 PDT 2025


https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/162358

The way this test was constructed made it difficult to test downstream divergence correctly; instead split the error case.

>From adaa81e58b7ae7b95f252cf1ec3892ad67bca5e3 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida <cyndy_ishida at apple.com>
Date: Tue, 7 Oct 2025 12:49:16 -0700
Subject: [PATCH] [tests] Split up darwin-macatalyst test

The way this test was constructed made it difficult to test
downstream divergence correctly, instead split the error case.
---
 clang/test/Driver/darwin-maccatalyst-error.c | 6 ++++++
 clang/test/Driver/darwin-maccatalyst.c       | 5 -----
 2 files changed, 6 insertions(+), 5 deletions(-)
 create mode 100644 clang/test/Driver/darwin-maccatalyst-error.c

diff --git a/clang/test/Driver/darwin-maccatalyst-error.c b/clang/test/Driver/darwin-maccatalyst-error.c
new file mode 100644
index 0000000000000..009249b268c8f
--- /dev/null
+++ b/clang/test/Driver/darwin-maccatalyst-error.c
@@ -0,0 +1,6 @@
+// RUN: not %clang -target x86_64-apple-ios13.0-macabi -c %s -### 2>&1 | \
+// RUN:   FileCheck --check-prefix=CHECK-ERROR %s
+// RUN: not %clang -target x86_64-apple-ios12.0-macabi -c %s -### 2>&1 | \
+// RUN:   FileCheck --check-prefix=CHECK-ERROR %s
+
+// CHECK-ERROR: error: invalid version number in '-target x86_64-apple-ios
diff --git a/clang/test/Driver/darwin-maccatalyst.c b/clang/test/Driver/darwin-maccatalyst.c
index 74a02ed945c51..a8d53df38d0e1 100644
--- a/clang/test/Driver/darwin-maccatalyst.c
+++ b/clang/test/Driver/darwin-maccatalyst.c
@@ -2,11 +2,6 @@
 // RUN:   FileCheck --check-prefix=CHECK-VERSION1 %s
 // RUN: %clang -target x86_64-apple-ios-macabi -c %s -### 2>&1 | \
 // RUN:   FileCheck --check-prefix=CHECK-VERSION1 %s
-// RUN: not %clang -target x86_64-apple-ios13.0-macabi -c %s -### 2>&1 | \
-// RUN:   FileCheck --check-prefix=CHECK-ERROR %s
-// RUN: not %clang -target x86_64-apple-ios12.0-macabi -c %s -### 2>&1 | \
-// RUN:   FileCheck --check-prefix=CHECK-ERROR %s
 
 // CHECK-VERSION1-NOT: error:
 // CHECK-VERSION1: "x86_64-apple-ios13.1.0-macabi"
-// CHECK-ERROR: error: invalid version number in '-target x86_64-apple-ios



More information about the cfe-commits mailing list