[clang] [analyzer] Avoid use of `CallEvent`s with obsolete state (PR #160707)

[Donát Nagy via cfe-commits]

NagyDonat wrote:

@steakhal With https://github.com/llvm/llvm-project/pull/160707/commits/16490339f0f9da77b715d8508586fdba3a534fe3 and https://github.com/llvm/llvm-project/pull/160707/commits/5b8416ff78af298c79bba14be0ecc2ca6e50daa2 I think I handled all your requests -- with the exception of adding tests, which turned out to be problematic (see my previous comment).

-----

The change https://github.com/llvm/llvm-project/pull/160707/commits/abccb02b867a1eaf980c97429fc39932ab4429d8 is just drive-by cleanup -- I noticed a typo (missing space) in a comment and I felt that it would be nice to fix it. I'm not strongly attached to it -- I can keep the typo if you would prefer minimizing the footprint of this change. 


https://github.com/llvm/llvm-project/pull/160707