[clang] [NFC][clang] Prefer triple overload of lookupTarget (PR #162185)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-driver

Author: Aiden Grossman (boomanaiden154)

<details>
<summary>Changes</summary>

The string overload will be deprecated soon, similar to other functions in TargetRegistry.

---
Full diff: https://github.com/llvm/llvm-project/pull/162185.diff


2 Files Affected:

- (modified) clang/lib/Testing/CommandLineArgs.cpp (+1-1) 
- (modified) clang/unittests/Driver/ToolChainTest.cpp (+1-1) 


``````````diff
diff --git a/clang/lib/Testing/CommandLineArgs.cpp b/clang/lib/Testing/CommandLineArgs.cpp
index e9da72f71c599..ae4ccb4e1e8d8 100644
--- a/clang/lib/Testing/CommandLineArgs.cpp
+++ b/clang/lib/Testing/CommandLineArgs.cpp
@@ -103,7 +103,7 @@ std::string getAnyTargetForTesting() {
     StringRef TargetName(Target.getName());
     if (TargetName == "x86-64")
       TargetName = "x86_64";
-    if (llvm::TargetRegistry::lookupTarget(TargetName, Error) == &Target) {
+    if (llvm::TargetRegistry::lookupTarget(llvm::Triple(TargetName), Error) == &Target) {
       return std::string(TargetName);
     }
   }
diff --git a/clang/unittests/Driver/ToolChainTest.cpp b/clang/unittests/Driver/ToolChainTest.cpp
index c1c5c9604aa16..afa17ff219be2 100644
--- a/clang/unittests/Driver/ToolChainTest.cpp
+++ b/clang/unittests/Driver/ToolChainTest.cpp
@@ -442,7 +442,7 @@ TEST(ToolChainTest, ParsedClangName) {
 TEST(ToolChainTest, GetTargetAndMode) {
   llvm::InitializeAllTargets();
   std::string IgnoredError;
-  if (!llvm::TargetRegistry::lookupTarget("x86_64", IgnoredError))
+  if (!llvm::TargetRegistry::lookupTarget(llvm::Triple("x86_64"), IgnoredError))
     GTEST_SKIP();
 
   ParsedClangName Res = ToolChain::getTargetAndModeFromProgramName("clang");

``````````

</details>


https://github.com/llvm/llvm-project/pull/162185