[clang] [Sema] Diagnose use of if/else-if condition variable inside else-if/else branch(s) (PR #156436)

[Erich Keane via cfe-commits]

================
@@ -13660,10 +13594,11 @@ def warn_acc_var_referenced_lacks_op
               "reference has no effect">,
       InGroup<DiagGroup<"openacc-var-lacks-operation">>,
       DefaultError;
+def warn_out_of_scope_var_usage
+    : Warning<"variable %0 declared in 'if' block is always false or null here">,
+      InGroup<DiagGroup<"conditional-scope">>;
----------------
erichkeane wrote:

ah, hmm... it should point to the `DeclRefExpr` not to the condition variable then.  We want to say "this use right here is wrong".

https://github.com/llvm/llvm-project/pull/156436