[clang] [Sema] Don't call isNonConstantStorage on incomplete variable types (PR #161590)

[Shafik Yaghmour via cfe-commits]

================
@@ -14919,7 +14919,7 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) {
 
   // Apply section attributes and pragmas to global variables.
   if (GlobalStorage && var->isThisDeclarationADefinition() &&
-      !inTemplateInstantiation()) {
+      !var->getDeclContext()->isDependentContext()) {
----------------
shafik wrote:

To fill in some details, it is more consistent and it is cheaper since `isDependentContext()` looks at all the parent contexts recursively. 

https://github.com/llvm/llvm-project/pull/161590