[clang] 65fd44e - [clang-linker-wrapper][NFC] Invert condition for readability (#161557)

[via cfe-commits]

Author: Alexey Bader
Date: 2025-10-01T10:54:18-07:00
New Revision: 65fd44eb0d9211035c4aaee85bc78e49c4682fab

URL: https://github.com/llvm/llvm-project/commit/65fd44eb0d9211035c4aaee85bc78e49c4682fab
DIFF: https://github.com/llvm/llvm-project/commit/65fd44eb0d9211035c4aaee85bc78e49c4682fab.diff

LOG: [clang-linker-wrapper][NFC] Invert condition for readability (#161557)

I find the positive expressions easier to read than negative.

Added: 
    

Modified: 
    clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Removed: 
    


################################################################################
diff  --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index be658acacb406..1419b8c90a625 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -608,10 +608,10 @@ Expected<StringRef> linkDevice(ArrayRef<StringRef> InputFiles,
 Error containerizeRawImage(std::unique_ptr<MemoryBuffer> &Img, OffloadKind Kind,
                            const ArgList &Args) {
   llvm::Triple Triple(Args.getLastArgValue(OPT_triple_EQ));
-  if (Kind != OFK_OpenMP || !Triple.isSPIRV() ||
-      Triple.getVendor() != llvm::Triple::Intel)
-    return Error::success();
-  return offloading::intel::containerizeOpenMPSPIRVImage(Img);
+  if (Kind == OFK_OpenMP && Triple.isSPIRV() &&
+      Triple.getVendor() == llvm::Triple::Intel)
+    return offloading::intel::containerizeOpenMPSPIRVImage(Img);
+  return Error::success();
 }
 
 Expected<StringRef> writeOffloadFile(const OffloadFile &File) {