[clang] [clang-linker-wrapper][NFC] Invert condition for readability (PR #161557)

Alexey Bader via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 1 10:32:40 PDT 2025


https://github.com/bader created https://github.com/llvm/llvm-project/pull/161557

I find the positive expressions easier to read than negative.

>From 9a83a881df29e95a4dbc98ece051a06032aa51bf Mon Sep 17 00:00:00 2001
From: Alexey Bader <alexey.bader at intel.com>
Date: Wed, 1 Oct 2025 10:31:59 -0700
Subject: [PATCH] [clang-linker-wrapper][NFC] Invert condition for readability

I find the positive expressions easier to read than negative.
---
 clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index be658acacb406..1419b8c90a625 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -608,10 +608,10 @@ Expected<StringRef> linkDevice(ArrayRef<StringRef> InputFiles,
 Error containerizeRawImage(std::unique_ptr<MemoryBuffer> &Img, OffloadKind Kind,
                            const ArgList &Args) {
   llvm::Triple Triple(Args.getLastArgValue(OPT_triple_EQ));
-  if (Kind != OFK_OpenMP || !Triple.isSPIRV() ||
-      Triple.getVendor() != llvm::Triple::Intel)
-    return Error::success();
-  return offloading::intel::containerizeOpenMPSPIRVImage(Img);
+  if (Kind == OFK_OpenMP && Triple.isSPIRV() &&
+      Triple.getVendor() == llvm::Triple::Intel)
+    return offloading::intel::containerizeOpenMPSPIRVImage(Img);
+  return Error::success();
 }
 
 Expected<StringRef> writeOffloadFile(const OffloadFile &File) {



More information about the cfe-commits mailing list