erichkeane wrote: This crossed in the air with https://github.com/llvm/llvm-project/pull/161431, so you'll see failures. I'm working on a patch to fix something else that came out of this review, so i'll fix those tests too. https://github.com/llvm/llvm-project/pull/161382