[clang] [clang][Dependency Scanning] Refactor Scanning Compiler Instance Initialization (PR #161300)

[Jan Svoboda via cfe-commits]

================
@@ -334,6 +336,17 @@ class ScanningDependencyDirectivesGetter : public DependencyDirectivesGetter {
 };
 } // namespace
 
+std::unique_ptr<DiagnosticOptions>
+clang::tooling::dependencies::createDiagOptions(
+    const std::vector<std::string> &CommandLine) {
----------------
jansvoboda11 wrote:

Seems like we could type-erase the `std::vector` with `ArrayRef` here an in lots of places.

https://github.com/llvm/llvm-project/pull/161300