[clang] [clang-scan-deps] Remove unused OutputsPaths from FullDependencyConsumer (NFC) (PR #155523)

Naveen Seth Hanig via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 28 18:59:33 PDT 2025


https://github.com/naveen-seth updated https://github.com/llvm/llvm-project/pull/155523

>From 25dbd63e641b6a84dab182ecd169567cc289a9e3 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig <naveen.hanig at outlook.com>
Date: Wed, 27 Aug 2025 01:46:21 +0200
Subject: [PATCH 1/2] [clang-scan-deps] Remove unused OutputsPaths in
 FullDependencyConsumer

The OutputPaths field of FullDependencyConsumer is not used, and the
resulting TranslationUnitDeps has no corresponding field. This change
removes the unused member.

It was added in commit f978ea4, and this comment in the Differential
Revision suggests it was intended to be removed before landing:
https://reviews.llvm.org/D70268#1772032
---
 .../clang/Tooling/DependencyScanning/DependencyScanningTool.h    | 1 -
 1 file changed, 1 deletion(-)

diff --git a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
index c3601a4e73e1f..f222ded8a966a 100644
--- a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
+++ b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
@@ -220,7 +220,6 @@ class FullDependencyConsumer : public DependencyConsumer {
   std::vector<std::string> VisibleModules;
   std::vector<Command> Commands;
   std::string ContextHash;
-  std::vector<std::string> OutputPaths;
   const llvm::DenseSet<ModuleID> &AlreadySeen;
 };
 

>From 3ce4655d2b8a1685f1bed36ce329c56f161dcc0f Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig <naveen.hanig at outlook.com>
Date: Mon, 29 Sep 2025 03:58:59 +0200
Subject: [PATCH 2/2] Remove const to allow true move

---
 clang/tools/clang-scan-deps/ClangScanDeps.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
index f10b73278381b..961f532ce2247 100644
--- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp
+++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -420,7 +420,7 @@ class FullDeps {
     std::vector<ModuleDeps *> NewMDs;
     {
       std::unique_lock<std::mutex> ul(Lock);
-      for (const ModuleDeps &MD : Graph) {
+      for (ModuleDeps &MD : Graph) {
         auto I = Modules.find({MD.ID, 0});
         if (I != Modules.end()) {
           I->first.InputIndex = std::min(I->first.InputIndex, InputIndex);



More information about the cfe-commits mailing list