[clang-tools-extra] [clang-tidy] Add check performance-lost-std-move (PR #139525)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE LINT COMMENT: clang-tidy-->


:warning: C/C++ code linter clang-tidy found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

```bash

git diff -U0 origin/main...HEAD -- clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.h clang-tools-extra/clang-tidy/performance/PerformanceTidyModule.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \
  -path build -p1 -quiet
```

</details>

<details>
<summary>
View the output from clang-tidy here.
</summary>

```


clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp:18:6: warning: function 'extractNodesByIdTo' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
   18 | void extractNodesByIdTo(ArrayRef<BoundNodes> Matches, StringRef ID,
      |      ^
      | static 
clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp:69:28: warning: function 'hasTrivialMoveConstructor' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
   69 | AST_MATCHER(CXXRecordDecl, hasTrivialMoveConstructor) {
      |                            ^
clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp:73:21: warning: function 'ignoreParens' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
   73 | AST_MATCHER_P(Expr, ignoreParens, ast_matchers::internal::Matcher<Expr>,
      |                     ^
clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp:74:15: warning: invalid case style for member 'innerMatcher' [readability-identifier-naming]
   74 |               innerMatcher) {
      |               ^~~~~~~~~~~~
      |               InnerMatcher
   75 |   return innerMatcher.matches(*Node.IgnoreParens(), Finder, Builder);
      |          ~~~~~~~~~~~~
      |          InnerMatcher
clang/include/clang/ASTMatchers/ASTMatchersMacros.h:131:58: note: expanded from macro 'AST_MATCHER_P'
  131 |   AST_MATCHER_P_OVERLOAD(Type, DefineMatcher, ParamType, Param, 0)
      |                                                          ^
clang/include/clang/ASTMatchers/ASTMatchersMacros.h:148:15: note: expanded from macro 'AST_MATCHER_P_OVERLOAD'
  148 |     ParamType Param;                                                           \
      |               ^
clang-tools-extra/clang-tidy/performance/LostStdMoveCheck.cpp:74:15: warning: invalid case style for parameter 'innerMatcher' [readability-identifier-naming]
   74 |               innerMatcher) {
      |               ^
clang/include/clang/ASTMatchers/ASTMatchersMacros.h:131:58: note: expanded from macro 'AST_MATCHER_P'
  131 |   AST_MATCHER_P_OVERLOAD(Type, DefineMatcher, ParamType, Param, 0)
      |                                                          ^
clang/include/clang/ASTMatchers/ASTMatchersMacros.h:157:59: note: expanded from macro 'AST_MATCHER_P_OVERLOAD'
  157 |       &DefineMatcher##_Type##OverloadId)(ParamType const &Param);              \
      |                                                           ^
note: this fix will not be applied because it overlaps with another fix
```

</details>


https://github.com/llvm/llvm-project/pull/139525