[clang] cafc064 - [clang] NFC: small formatting and stray whitespace cleanup

Matheus Izvekov via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 21 16:09:16 PDT 2025


Author: Matheus Izvekov
Date: 2025-09-21T20:06:20-03:00
New Revision: cafc064fc7a96b3979a023ddae1da2b499d6c954

URL: https://github.com/llvm/llvm-project/commit/cafc064fc7a96b3979a023ddae1da2b499d6c954
DIFF: https://github.com/llvm/llvm-project/commit/cafc064fc7a96b3979a023ddae1da2b499d6c954.diff

LOG: [clang] NFC: small formatting and stray whitespace cleanup

Formats `Expr::HasSideEffects` because incorrect identation of block end token
makes clang-format go haywire in patch mode.

Also removes stray whitespace from a test file.

Added: 
    

Modified: 
    clang/lib/AST/Expr.cpp
    clang/test/SemaCXX/delete-and-function-templates.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp
index 6ef7e54ec00b9..f899b3c4bb79c 100644
--- a/clang/lib/AST/Expr.cpp
+++ b/clang/lib/AST/Expr.cpp
@@ -3672,10 +3672,10 @@ bool Expr::HasSideEffects(const ASTContext &Ctx,
 
   switch (getStmtClass()) {
   case NoStmtClass:
-  #define ABSTRACT_STMT(Type)
-  #define STMT(Type, Base) case Type##Class:
-  #define EXPR(Type, Base)
-  #include "clang/AST/StmtNodes.inc"
+#define ABSTRACT_STMT(Type)
+#define STMT(Type, Base) case Type##Class:
+#define EXPR(Type, Base)
+#include "clang/AST/StmtNodes.inc"
     llvm_unreachable("unexpected Expr kind");
 
   case DependentScopeDeclRefExprClass:
@@ -3831,8 +3831,8 @@ bool Expr::HasSideEffects(const ASTContext &Ctx,
     break;
 
   case GenericSelectionExprClass:
-    return cast<GenericSelectionExpr>(this)->getResultExpr()->
-        HasSideEffects(Ctx, IncludePossibleEffects);
+    return cast<GenericSelectionExpr>(this)->getResultExpr()->HasSideEffects(
+        Ctx, IncludePossibleEffects);
 
   case ChooseExprClass:
     return cast<ChooseExpr>(this)->getChosenSubExpr()->HasSideEffects(
@@ -3856,7 +3856,7 @@ bool Expr::HasSideEffects(const ASTContext &Ctx,
     if (DCE->getTypeAsWritten()->isReferenceType() &&
         DCE->getCastKind() == CK_Dynamic)
       return true;
-    }
+  }
     [[fallthrough]];
   case ImplicitCastExprClass:
   case CStyleCastExprClass:
@@ -3945,7 +3945,7 @@ bool Expr::HasSideEffects(const ASTContext &Ctx,
   case ObjCBridgedCastExprClass:
   case ObjCMessageExprClass:
   case ObjCPropertyRefExprClass:
-  // FIXME: Classify these cases better.
+    // FIXME: Classify these cases better.
     if (IncludePossibleEffects)
       return true;
     break;

diff  --git a/clang/test/SemaCXX/delete-and-function-templates.cpp b/clang/test/SemaCXX/delete-and-function-templates.cpp
index bc46f17a8c171..b5854d3073c03 100644
--- a/clang/test/SemaCXX/delete-and-function-templates.cpp
+++ b/clang/test/SemaCXX/delete-and-function-templates.cpp
@@ -1,7 +1,7 @@
 // RUN: %clang_cc1 -std=c++11 -verify  -emit-llvm-only %s
-// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only  -fdelayed-template-parsing %s 
-// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only  -fms-extensions %s 
-// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only  -fdelayed-template-parsing -fms-extensions %s 
+// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only  -fdelayed-template-parsing %s
+// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only  -fms-extensions %s
+// RUN: %clang_cc1 -std=c++11 -verify -fsyntax-only  -fdelayed-template-parsing -fms-extensions %s
 
 template<class T, class U> struct is_same { enum { value = false }; };
 template<class T> struct is_same<T, T> { enum { value = true }; };
@@ -53,7 +53,7 @@ namespace test_explicit_specialization_of_member {
 namespace ns1 {
 template<class T> struct X {
   int* f(T) = delete;
-}; 
+};
 template<> int* X<int>::f(int) { }
 
 template<class T> decltype(X<T>{}.f(T{})) g(T); // expected-note{{candidate}}
@@ -69,7 +69,7 @@ void foo() {
 namespace ns2 {
 struct X {
 template<class T> double* f(T) = delete;
-}; 
+};
 template<> double* X::f(int);
 
 template<class T> decltype(X{}.f(T{})) g(T); // expected-note{{candidate}}
@@ -105,8 +105,8 @@ void foo() {
    int *ip4 = g2(3, 3); //expected-error{{ambiguous}}
   }
   {
-   int *ip3 = g2(3.14, 3.14); 
-   int *ip4 = g2(3, 3.14); 
+   int *ip3 = g2(3.14, 3.14);
+   int *ip4 = g2(3, 3.14);
   }
 }
 


        


More information about the cfe-commits mailing list