[clang] [analyzer] Correct crash in Z3 wrapper (PR #158276)

[Donát Nagy via cfe-commits]

https://github.com/NagyDonat commented:

I agree that it's unfortunate that we don't have a more general solution for this problem. However, not crashing is still better than crashing, so if nobody has capacity to develop a more general solution, then I think we should still merge this PR (with big TODO notes that ask for a later cleanup) because it's better than the status quo.

Unfortunately I'm not familiar with this "glue" code between the analyzer and Z3, so I cannot help with developing a better solution for this in the foreseeable future. If I understand correctly @vabridgers is also leaning towards merging this quickfix instead of investing additional work into systemic improvements of this area.

@steakhal What do you think about this?

https://github.com/llvm/llvm-project/pull/158276