[clang] 5b13d99 - Revert "[Clang] Enable lit internal shell by default"
Aiden Grossman via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 19 22:57:24 PDT 2025
Author: Aiden Grossman
Date: 2025-09-20T05:56:57Z
New Revision: 5b13d99357d5113b0ee4cde2066a024e1df58222
URL: https://github.com/llvm/llvm-project/commit/5b13d99357d5113b0ee4cde2066a024e1df58222
DIFF: https://github.com/llvm/llvm-project/commit/5b13d99357d5113b0ee4cde2066a024e1df58222.diff
LOG: Revert "[Clang] Enable lit internal shell by default"
This reverts commit 25e218d7562f1f360a8f112de2b771585cd922c3.
This is causing errors on the llvm-clang-aarch64-darwin builder related
to too many files being open.
Added:
Modified:
clang/test/lit.cfg.py
Removed:
################################################################################
diff --git a/clang/test/lit.cfg.py b/clang/test/lit.cfg.py
index cfcbf904103d4..4a5d9e582b54c 100644
--- a/clang/test/lit.cfg.py
+++ b/clang/test/lit.cfg.py
@@ -18,22 +18,11 @@
# name: The name of this test suite.
config.name = "Clang"
-# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites.
-# See https://github.com/llvm/llvm-project/issues/106636 for more details.
-#
-# We prefer the lit internal shell which provides a better user experience on failures
-# and is faster unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0
-# env var.
-use_lit_shell = True
-lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
-if lit_shell_env:
- use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
-
# testFormat: The test format to use to interpret tests.
#
# For now we require '&&' between commands, until they get globally killed and
# the test runner updated.
-config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)
+config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
# suffixes: A list of file extensions to treat as test files.
config.suffixes = [
More information about the cfe-commits
mailing list