[clang] [analyzer] Correct crash in Z3 wrapper (PR #158276)

[via cfe-commits]

================
@@ -13,3 +13,29 @@ int negate(int x, int y) {
     return 0;
   return 1;
 }
+
+void c();
+void case004(int *a, int *b) {
+  void *e;
+  b != a;
+  c(e); // expected-warning{{1st function call argument is an uninitialized value}}
+}
+
+void z3crash(int a, int b) {
+  b = a || b;
+  (-b == a) / a; // expected-warning{{expression result unused}}
----------------
vabridgers wrote:

This case ends up with the  same SymExpr as the one I originally found for some reason.  : -((reg_$2<int b>) != 0) : which is why I thought it was useful to include this. The cases found were from a combination of randomized testing and reduction from code analysis runs on internal test cases. We do not intended on taking up the activity of exploring all possible ways of exposing this problem since that seems like an unbounded activity, but we think it's better to patch up the crashes for now. Thanks

https://github.com/llvm/llvm-project/pull/158276