[clang] [CIR][NFC] Remove Covered MissingFeatures flags for Complex (PR #158425)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Sep 13 07:37:37 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Amr Hesham (AmrDeveloper)
<details>
<summary>Changes</summary>
Remove Covered MissingFeatures flags for Complex
---
Full diff: https://github.com/llvm/llvm-project/pull/158425.diff
3 Files Affected:
- (modified) clang/include/clang/CIR/MissingFeatures.h (-2)
- (modified) clang/lib/CIR/Dialect/IR/CIRDialect.cpp (-3)
- (modified) clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp (-2)
``````````diff
diff --git a/clang/include/clang/CIR/MissingFeatures.h b/clang/include/clang/CIR/MissingFeatures.h
index 52d5f8a2ded2c..60e0aa163dc04 100644
--- a/clang/include/clang/CIR/MissingFeatures.h
+++ b/clang/include/clang/CIR/MissingFeatures.h
@@ -296,8 +296,6 @@ struct MissingFeatures {
// Future CIR operations
static bool awaitOp() { return false; }
static bool callOp() { return false; }
- static bool complexImagOp() { return false; }
- static bool complexRealOp() { return false; }
static bool ifOp() { return false; }
static bool invokeOp() { return false; }
static bool labelOp() { return false; }
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 24aef693024f7..8918eb4cbb1ad 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -1754,9 +1754,6 @@ LogicalResult cir::BinOp::verify() {
return emitError() << "The nsw/nuw flags and the saturated flag are "
"mutually exclusive";
- assert(!cir::MissingFeatures::complexType());
- // TODO(cir): verify for complex binops
-
return mlir::success();
}
diff --git a/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp b/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
index d41ea0af58938..fbecab9774f5b 100644
--- a/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
+++ b/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
@@ -134,8 +134,6 @@ void CIRCanonicalizePass::runOnOperation() {
getOperation()->walk([&](Operation *op) {
assert(!cir::MissingFeatures::switchOp());
assert(!cir::MissingFeatures::tryOp());
- assert(!cir::MissingFeatures::complexRealOp());
- assert(!cir::MissingFeatures::complexImagOp());
assert(!cir::MissingFeatures::callOp());
// Many operations are here to perform a manual `fold` in
``````````
</details>
https://github.com/llvm/llvm-project/pull/158425
More information about the cfe-commits
mailing list