[clang] 2f9a458 - [WebKit checkers] Treat asm brk as trivial (#155046)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 11 14:50:03 PDT 2025
Author: Ryosuke Niwa
Date: 2025-09-11T14:49:59-07:00
New Revision: 2f9a458f35ccd0fc45067afda346fd59052d0c0c
URL: https://github.com/llvm/llvm-project/commit/2f9a458f35ccd0fc45067afda346fd59052d0c0c
DIFF: https://github.com/llvm/llvm-project/commit/2f9a458f35ccd0fc45067afda346fd59052d0c0c.diff
LOG: [WebKit checkers] Treat asm brk as trivial (#155046)
Like other functions which results in abort, treat asm brk instruction
as trivial.
Added:
clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
Modified:
clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
Removed:
################################################################################
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
index 884dbe90e7b12..56747d72136e3 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
@@ -666,6 +666,10 @@ class TrivialFunctionAnalysisVisitor
return IsFunctionTrivial(Callee);
}
+ bool VisitGCCAsmStmt(const GCCAsmStmt *AS) {
+ return AS->getAsmString() == "brk #0xc471";
+ }
+
bool
VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
// Non-type template paramter is compile time constant and trivial.
diff --git a/clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp b/clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
new file mode 100644
index 0000000000000..de98c77eb7347
--- /dev/null
+++ b/clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
@@ -0,0 +1,22 @@
+// RUN: %clang_analyze_cc1 -triple arm-darwin -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
+// expected-no-diagnostics
+
+void crash()
+{
+ __asm__ volatile ("brk #0xc471");
+ __builtin_unreachable();
+}
+
+class SomeObj {
+public:
+ void ref();
+ void deref();
+
+ void someWork() { crash(); }
+};
+
+SomeObj* provide();
+
+void doSomeWork() {
+ provide()->someWork();
+}
More information about the cfe-commits
mailing list