[clang] [analyzer] Improve messaging in security.VAList (PR #157846)

[Balazs Benics via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/157846 at github.com>


================
@@ -101,8 +101,8 @@ void recopy(int fst, ...) {
   va_list va, va2;
   va_start(va, fst);
   va_copy(va2, va); // expected-note{{Initialized va_list}}
-  va_copy(va2, va); // expected-warning{{Initialized va_list 'va2' is initialized again}}
-  // expected-note at -1{{Initialized va_list 'va2' is initialized again}}
+  va_copy(va2, va); // expected-warning{{Initialized va_list 'va2' is overwritten by another initialized one}}
+  // expected-note at -1{{Initialized va_list 'va2' is overwritten by another initialized one}}
----------------
steakhal wrote:

I wonder if all the code paths are covered in the message generation and table lookups in this patch.
I was surprised only how few of the tests were affected by the message improvements; which was a red flag to me.

https://github.com/llvm/llvm-project/pull/157846