[clang] [clang-tools-extra] [clang-tidy] `bugprone-unchecked-optional-access`: handle `BloombergLP::bdlb:NullableValue::makeValue` to prevent false-positives (PR #144313)

[Baranov Victor via cfe-commits]

================
@@ -201,6 +201,11 @@ Changes in existing checks
   namespace are treated as the tag or the data part of a user-defined
   tagged union respectively.
 
+- Improved :doc:`bugprone-unchecked-optional-access
+  <clang-tidy/checks/bugprone/unchecked-optional-access>` check by supporting 
+  `NullableValue::makeValue` and `NullableValue::makeValueInplace` to prevent 
+  false-positives for `BloombergLP::bdlb::NullableValue` type.
----------------
vbvictor wrote:

Strangely, "apply from github UI" doesn't work for this diff

https://github.com/llvm/llvm-project/pull/144313