[clang] [analyzer] In LivenessValues::equals also check liveBindings (PR #157645)

Balazs Benics via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 9 04:00:39 PDT 2025


https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/157645

This was likely accidentally omitted when `liveBindings` was introduced. I don't think in practice it matters.

>From 99e2c1391b0a4e9b7ccc412087202d60b89d08f4 Mon Sep 17 00:00:00 2001
From: Balazs Benics <benicsbalazs at gmail.com>
Date: Tue, 9 Sep 2025 12:50:13 +0200
Subject: [PATCH] [analyzer] In LivenessValues::equals also check liveBindings

This was likely accidentally omitted when `liveBindings` was introduced.
I don't think in practice it matters.
---
 clang/lib/Analysis/LiveVariables.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/clang/lib/Analysis/LiveVariables.cpp b/clang/lib/Analysis/LiveVariables.cpp
index 375fdb3695e2f..db88d4f7ee0f7 100644
--- a/clang/lib/Analysis/LiveVariables.cpp
+++ b/clang/lib/Analysis/LiveVariables.cpp
@@ -128,7 +128,8 @@ LiveVariablesImpl::merge(LiveVariables::LivenessValues valsA,
 }
 
 bool LiveVariables::LivenessValues::equals(const LivenessValues &V) const {
-  return liveExprs == V.liveExprs && liveDecls == V.liveDecls;
+  return liveExprs == V.liveExprs && liveDecls == V.liveDecls &&
+         liveBindings == V.liveBindings;
 }
 
 //===----------------------------------------------------------------------===//



More information about the cfe-commits mailing list