[clang] [clang][bytecode][NFC] Remove some unnecessary if statements (PR #157329)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Sep 7 00:32:50 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
<details>
<summary>Changes</summary>
We already checked that `IsStatic` is true above.
---
Full diff: https://github.com/llvm/llvm-project/pull/157329.diff
1 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+3-10)
``````````diff
diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
index d4e10b32c470c..90145fe08ef3d 100644
--- a/clang/lib/AST/ByteCode/Compiler.cpp
+++ b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -2924,13 +2924,8 @@ bool Compiler<Emitter>::VisitMaterializeTemporaryExpr(
if (SubExprT) {
if (!this->visit(SubExpr))
return false;
- if (IsStatic) {
- if (!this->emitInitGlobalTemp(*SubExprT, *GlobalIndex, TempDecl, E))
- return false;
- } else {
- if (!this->emitInitGlobal(*SubExprT, *GlobalIndex, E))
- return false;
- }
+ if (!this->emitInitGlobalTemp(*SubExprT, *GlobalIndex, TempDecl, E))
+ return false;
return this->emitGetPtrGlobal(*GlobalIndex, E);
}
@@ -2941,9 +2936,7 @@ bool Compiler<Emitter>::VisitMaterializeTemporaryExpr(
return false;
if (!this->visitInitializer(SubExpr))
return false;
- if (IsStatic)
- return this->emitInitGlobalTempComp(TempDecl, E);
- return true;
+ return this->emitInitGlobalTempComp(TempDecl, E);
}
// For everyhing else, use local variables.
``````````
</details>
https://github.com/llvm/llvm-project/pull/157329
More information about the cfe-commits
mailing list