[clang] [Clang-Repl] Sinking RemoteJITUtils into Interpreter class(Refactoring) (PR #155140)

[Vassil Vassilev via cfe-commits]

================
@@ -533,11 +655,19 @@ llvm::Error Interpreter::CreateExecutor() {
   }
 
   llvm::Error Err = llvm::Error::success();
+
+  // Fix: Declare Executor as the appropriate unique_ptr type
+  std::unique_ptr<IncrementalExecutor> Executor;
+
 #ifdef __EMSCRIPTEN__
-  auto Executor = std::make_unique<WasmIncrementalExecutor>(*TSCtx);
+  Executor = std::make_unique<WasmIncrementalExecutor>(*TSCtx);
 #else
-  auto Executor =
-      std::make_unique<IncrementalExecutor>(*TSCtx, *JITBuilder, Err);
+  if (IsWindowsTarget) {
+    Executor = std::make_unique<IncrementalExecutor>(*TSCtx, *JITBuilder, Err);
+  } else {
+    Executor = std::make_unique<IncrementalExecutor>(*TSCtx, *JITBuilder, Err,
+                                                     OOPChildPid);
----------------
vgvassilev wrote:

We should pass `Config` here and move the checks in the `IncrementalExecutor` constructor. That would drop the need of having a separate `IsWindowsTarget` branch.

https://github.com/llvm/llvm-project/pull/155140